Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add panel visibility hooks #36

Merged
merged 4 commits into from
Aug 5, 2023
Merged

Add panel visibility hooks #36

merged 4 commits into from
Aug 5, 2023

Conversation

StyledStrike
Copy link
Contributor

This calls two new hooks:

  • MapVote_PanelOpened, when the vote frame is shown/opened
  • MapVote_PanelClosed, when the vote frame is hidden/closed

plally
plally requested changes Aug 4, 2023
View reviewed changes
Copy link
Member

@plally plally left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A more specific name might be better e.g. MapVote_VotePanelOpened"

Could you add the hooks to the README as well

lua/mapvote/client/vgui/frame.lua Outdated Show resolved Hide resolved
@plally plally merged commit 1a256e4 into CFC-Servers:main Aug 5, 2023
1 check passed
@StyledStrike StyledStrike deleted the add-panel-visible-hooks branch August 5, 2023 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plally plally plally approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StyledStrike @plally