New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logic spaghetti #11

Open

loganlearner opened this issue Oct 31, 2021 · 0 comments

Contributor

loganlearner commented Oct 31, 2021 •

edited

Loading

cfc_pvp_weapons/lua/weapons/cfc_weapon_parachute/init.lua

Lines 288 to 294 in 7b5cf00

    
           local prevState = self.chuteIsUnstable 
        
           if state == nil then 
        
               state = not prevState 
        
           elseif state == prevState then return end 
        
           self.chuteIsUnstable = state

Couldn't this section be simplified to:

self.chuteIsUnstable = state == nil and not self.chuteIsUnstable or state

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment