Fix compilation and printing of extensions in rpc in/out #2281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The extensions are compiled once in lys_compile_node_action_inout(), then another time in lys_compile_node_(), which adds the same extensions again. Remove the extension compilation from lys_compile_node_action_inout(). Signed-off-by: Olivier Matz <[email protected]>
Fix the substatement passed to yprp_extension_instances() from yprp_inout(). Signed-off-by: Olivier Matz <[email protected]>
|
LGTM ;) It rings a bell. |
michalvasko
approved these changes
Aug 12, 2024
|
Thanks, this seems to be leftover code from when these nodes worked differently, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These 2 commits fix the compilation and the printing of extensions in rpc input and output nodes.
Fixes #2276
Fixes #2280