Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python interpreter and Library mis-match causes installation to succeed while pysparse is not installed #157

Open
chaithyagr opened this issue May 20, 2021 · 0 comments
Assignees

Comments

@chaithyagr
Copy link
Contributor

Currently, in the CMake file here:

find_package(PythonInterp REQUIRED)
if(NOT DEFINED PYTHON_LIBRARIES OR NOT DEFINED PYTHON_INCLUDE_DIRS)
find_package(PythonLibs REQUIRED)
else()
message(STATUS "Using Python Lib: ${PYTHON_LIBRARIES}")
message(STATUS "Using Python Inc: ${PYTHON_INCLUDE_DIRS}")
endif()
include_directories(${PYTHON_INCLUDE_DIRS})

There is no check if the python interpreter and python libraries are the same version or not. This miss-match can cause a lot of issues..

As a first step, we can limit the python versions to >= 3.6 here. Most of recent versions can handle backward compatibilities, making this not such a big issue.

@chaithyagr chaithyagr changed the title Python interpreter and version mis-match causes installation to succeed while pysparse is not installed Python interpreter and Library mis-match causes installation to succeed while pysparse is not installed May 20, 2021
@sfarrens sfarrens self-assigned this Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants