Nested aggregations #128
Open
Nested aggregations #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
now it works on nested or non-nested queries (i.e. title[court_k#Circuit Court]). |
this is not the most semantically correct, but it doesn't break anything and orchid seems to expect it
this is necessary to make this sort of query work
wkdewey
force-pushed
the
nested-aggregations
branch
from
4d08703
to
16a490d
Compare
Closed
Closed
|
renamed the branch, see above, closing |
|
reopening, this is a better branch name since we don't want to use the |
This was
linked to
issues
Dec 6, 2022
Open
|
all the commits are in #128 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will fix #124 (see also CDRH/orchid#228 on the orchid end). Needs to be generalized to handle ordinary as well as nested facets, currently it does only nested.