Bug fix: Add units to lab component values

[angelathe]

PULL REQUEST

Summary

• Update FHIR path to include units to lab component values if available
• Update test lab bundle to include example of value/units in snapshot test

Related Issue

Fixes #2671

Acceptance Criteria

• If units are available, they should be concatenated to the value

Screenshots

Before (10e5b07b-5d3f-426f-a7e1-13ea909ff5a5):

After (10e5b07b-5d3f-426f-a7e1-13ea909ff5a5):

Checklist

Examples from QA process:

• 3d607116-9e59-4e42-a084-c5cff4b023f1: Unit of measurement not displayed for relevant lab results
• 10e5b07b-5d3f-426f-a7e1-13ea909ff5a5: Unit of value is not displayed (Ex. should display 38%, 95%, etc.)
• 3a6febc6-cc0f-4706-8322-da0cd16bb7c6: Not displaying units for result value — relevant to all lab results
• TN_sample eCR2: Units for lab component values are not displayed when info is available
• TN_sample eCR4: Units for lab component values aren’t displayed when info is available
• 5370592c-6dd3-4de5-b4f6-8a2f4b0253aa: Value is missing data (%)

[angelathe]

@ashton-skylight Hi, this is ready for review!

Just a quick question, do you have any thoughts on whether or not you want a space between the value and the unit? Right now, there's a space, so that something like 5 g/mL would be more readable, but that also means that there would be a space for something like 50 %.

[mcmcgrath13]

if the value quantity unit and interpretation coding display both exist, would we get double units now?

[angelathe]

I don't believe so! The interpretation coding usually interprets the value, i.e. High or Low, but it does not include the units itself.

Screenshot below of example when both unit and interpretation coding both exist:

[mcmcgrath13]

thanks! the fhirpath logic is a lot to parse (as a human) there - do you think it would be worth adding a comment, something like

# <value> <units> (<flag>)

[angelathe]

Added! TY Mary!

[ashton-skylight]

@angelathe This looks great! Is there a way that we could remove the space for %?

[angelathe]

@angelathe This looks great! Is there a way that we could remove the space for %?

Hi @ashton-skylight, yes we can! Should that also be the case for units under the Ref Range column? Example below.

[ashton-skylight]

@angelathe Amazing yes please! Preferably, it would be best to only remove the space for percentages in the value and ref range. If removing the space in the % affects everything (ie. M/ml or days), we'll keep it with the space as is.

[angelathe]

@angelathe Amazing yes please! Preferably, it would be best to only remove the space for percentages in the value and ref range. If removing the space in the % affects everything (ie. M/ml or days), we'll keep it with the space as is.

Making a note that fixing the ref range unit spacing will be be made into its own ticket

[mcmcgrath13]

thanks!