Split section out from the ContentContainer component #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakewheeler
commented
Dec 9, 2024
src/app/page.tsx
Outdated
|
|
||
| return ( | ||
| <ContentContainer sectionClasses={styles.valueSection} align> | ||
| <section> |
There was a problem hiding this comment.
The diff makes this look like a lot of changes but I'm just wrapping these section components in section tags.
There was a problem hiding this comment.
Same thing for the other files below.
nickbristow
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
sectiontag that was previously within theContentContainerContentContainerhowever we want without introducingsectiontags that don't make sensesectiontags to existing components that need themThis PR should not introduce any visible changes.