Modify nav link underline to match design #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakewheeler
commented
Nov 25, 2024
Comment on lines
49
to
52
| const pathSegments = pathname.split('/').filter((segment) => segment !== ''); | ||
| if (pathSegments.length > 0 && url.toString().includes(pathSegments[0])) { | ||
| return true; | ||
| } |
There was a problem hiding this comment.
Definitely open to suggestions here if there is a better way to handle this.
There was a problem hiding this comment.
Maybe this
function useIsActive(url: NavigationLinkProps['href']) {
const pathname = usePathname();
const urlStr = url.toString();
return (
pathname === urlStr ||
(pathname.startsWith(urlStr) && (urlStr !== '/' || pathname === '/'))
);
}
nickbristow
requested changes
Dec 10, 2024
Comment on lines
49
to
52
| const pathSegments = pathname.split('/').filter((segment) => segment !== ''); | ||
| if (pathSegments.length > 0 && url.toString().includes(pathSegments[0])) { | ||
| return true; | ||
| } |
There was a problem hiding this comment.
Maybe this
function useIsActive(url: NavigationLinkProps['href']) {
const pathname = usePathname();
const urlStr = url.toString();
return (
pathname === urlStr ||
(pathname.startsWith(urlStr) && (urlStr !== '/' || pathname === '/'))
);
}
nickbristow
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the currently selected NavLink's underline to be offset, which more closely resembles the Figma design.
I've also created the
useIsActivehook, which is used to check whether we are currently on a parent page or a child page of one of the parent pages.For example, navigating to
/productsor/products/ecr-viewershould cause the "Our products" NavLink to be underlined now, as the Figma designs show.