Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Home Content Updates #14

Merged
merged 5 commits into from
Nov 27, 2023
Merged

Home Content Updates #14

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
208b251
Content updates
KennethSkylight Nov 8, 2023
3b7cab9
fixing background color
KennethSkylight Nov 13, 2023
36d682a
fixing lint
KennethSkylight Nov 15, 2023
0afb5fb
Merge branch 'main' into kenneth/home-content-updates
KennethSkylight Nov 27, 2023
287752f
Addressing PR comments, fixing a build issue
KennethSkylight Nov 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
84 changes: 36 additions & 48 deletions pages/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ export default function Home() {
<h1
className={`${styles.headerText} ${styles.dynamicHeader} header-line-height text-accent-cool-darker font-bold maxw-mobile-lg padding-x-1 desktop:padding-x-0`}
>
Reponse-ready public health data systems
Streamlining public health data processing
</h1>
<p
className={`font-public-sans line-height-sans-6 font-semibold ${styles.letterSpacingNeg1} padding-right-1 desktop:padding-right-0`}
Expand All @@ -46,11 +46,10 @@ export default function Home() {
</p>
<br />
<p className="font-public-sans line-height-sans-6 padding-right-05 desktop:padding-right-0">
The Public Health Data Infrastructure (PHDI) project is part of
the Pandemic-Ready Interoperability Modernization Effort (PRIME),
a multi-year collaboration between CDC and the U.S. Digital
Service (USDS) to strengthen data quality and information
technology systems in public health departments.
The Data Integration Building Blocks (DIBBs) team,
formerly known as the Public Health Data Infrastructure (PHDI) project,
develops open source, cloud-based tools that public health departments can
integrate into their current workflows to improve data quality and reliability.
</p>
</div>
<div
Expand Down Expand Up @@ -78,42 +77,39 @@ export default function Home() {
<h2
className={`${styles.headerText} header-line-height text-accent-cool-darker font-bold desktop:padding-right-7 padding-y-205`}
>
An introduction to Building Blocks and data modernization
How we can help
</h2>
<div className="text-base-darkest line-height-sans-6">
PHDI&apos;s current body of work also falls within the scope
of CDC&apos;s&nbsp;
<span className="font-semibold text-underline text-primary link">
<a
className="underline text-primary"
href="https://www.cdc.gov/surveillance/projects/dmi-initiative/index.html"
target='_blank'
rel="noreferrer">
Data Modernization Initiative (DMI)
</a>
</span>
,&nbsp;which is an effort to modernize core public health data
and surveillance infrastructure across the federal and state
public health landscape.
<div className="text-base-darkest line-height-sans-6 font-public-sans line-height-sans">
<p className="font-semibold">
Automate your public health data processing so you can focus on taking meaningful public
health action
</p>
<br />
<p>
Our interdisciplinary team of researchers and engineers works to solve your jurisdiction&apos;s data challenges
and integrate our flexible, modern tools into your existing workflows
</p>
<br />
<span className="desktop:padding-right-5">
PHDI&apos;s work focuses on building and providing access to
open source, modular software and tooling, known as
“Building Blocks,” that states, territories, localities,
tribes (STLTs), and other public health actors can integrate
into their current workflows to reduce manual processes and
solve challenges when working with public health data. Some
Building Blocks offer relatively simple functionality, like
standardizing patient names, while others perform more
complex tasks, including geocoding and standardizing
addresses.
</span>
<p className="font-semibold">
Improve the quality and completeness of your data
</p>
<br />
<p>
Using a pipeline of modular software components known as Building Blocks, we validate,
clean, standardize, and enrich your data — all while reducing the need for manual processes
</p>
<br />
<p className="font-semibold">
Get the data that you need in the format that you want it
</p>
<br />
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not be using <br/> to create spaces between paragraphs. We should use CSS, something like the one below, or create a new CSS class.

 p {
   margin-bottom: 16px; 
 }

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/br

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed with Josh here, the problem is
and screen readers don't play well so its an accessibility issue. Looks like it may have been like that before this PR but it should be an easy tweak to fix here? Other than that this PR looks great tho!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed it

<p>
We want to understand your unique data needs and assess how our tooling could make your data more usable
</p>
<br />
<div className="font-semibold text-underline text-primary link">
<Link href="/building-block-info">
More about Building Blocks ›
Learn about what we&apos;ve built ›
</Link>
</div>
</div>
Expand All @@ -127,12 +123,7 @@ export default function Home() {
Our pilot partners
</h2>
<p className="text-center text-base-darkest line-height-sans-6 padding-x-3 desktop:padding-x-9">
We work with a range of public health departments to develop and
iterate on Building Blocks that solve healthcare
<br className="display-inline desktop:display-none" />
data-related challenges{' '}
<br className="display-inline desktop:display-none" />
within their organizations.
We work with public health departments to solve their toughest data challenges
</p>
<div className="grid-row margin-top-6">
<div className="desktop:grid-col-6">
Expand Down Expand Up @@ -183,22 +174,19 @@ export default function Home() {
<div
className={`position-relative ${styles.desktopHeroImage3} maxw-mobile-lg margin-x-auto`}
>
<h2 className="text-center text-bold text-white header-line-height padding-y-205">
An invitation to participate
<h2 className="text-center text-bold text-white header-line-height padding-y-205 padding-x-205">
Want to connect with us?
</h2>
<p className="line-height-sans-6 text-white text-center padding-x-4 desktop:padding-x-1">
We are currently gathering input from public health agencies and
partners to help us define and prioritize future Building Blocks
that can help efficiently and effectively collect, use, analyze,
and share public health data.
Our team will respond to your questions or set up a time to discuss how we can support your work.
</p>
<div className="text-center margin-top-3 width-card-lg margin-x-auto">
<Link href="/partner-with-us">
<Button
outline
className={`${styles.buttonAccent} desktop:padding-x-4 padding-y-2`}
>
Get Involved
Contact Us
</Button>
</Link>
</div>
Expand Down
6 changes: 3 additions & 3 deletions styles/Home.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
}

.desktopHeroImage2 {
margin-bottom: -77px;
margin-bottom: -132px;
}

.dekstopHeroImage1 {
Expand Down Expand Up @@ -52,7 +52,7 @@

@media(min-width:1024px) {
.desktopHeroImage3 {
margin-top: -340px;
margin-top: -289px;
margin-bottom: 0px;
}

Expand Down Expand Up @@ -114,7 +114,7 @@
}

.backgroundInvitation {
background-color: #07648d;
background-color: #28A0CB;
}

.navbarItemText {
Expand Down
Loading