Home Content Updates #14
Conversation
|
@KennethSkylight could you provide a screenshot of the middle of the page? everything you sent looks good but I can't get a good sense of what the full middle section looks like (How we can help section) |
|
@sarahtress got it |
|
Oops didn't link the screenshot 
|
|
@KennethSkylight looks good to me, thanks! |
pages/index.js
Outdated
| <p className="font-semibold"> | ||
| Get the data that you need in the format that you want it | ||
| </p> | ||
| <br /> |
There was a problem hiding this comment.
We should not be using <br/> to create spaces between paragraphs. We should use CSS, something like the one below, or create a new CSS class.
p {
margin-bottom: 16px;
}
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/br
There was a problem hiding this comment.
Agreed with Josh here, the problem is
and screen readers don't play well so its an accessibility issue. Looks like it may have been like that before this PR but it should be an easy tweak to fix here? Other than that this PR looks great tho!
There was a problem hiding this comment.
I changed it
pages/index.js
Outdated
| <p className="font-semibold"> | ||
| Get the data that you need in the format that you want it | ||
| </p> | ||
| <br /> |
There was a problem hiding this comment.
Agreed with Josh here, the problem is
and screen readers don't play well so its an accessibility issue. Looks like it may have been like that before this PR but it should be an easy tweak to fix here? Other than that this PR looks great tho!
Added content updates for the home page
Screenshot 1
Screenshot 2
Screenshot 3