Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update database-services.ts getCustomQueries #169

Open
robertandremitchell opened this issue Nov 20, 2024 — with Linear · 1 comment
Open

Update database-services.ts getCustomQueries #169

robertandremitchell opened this issue Nov 20, 2024 — with Linear · 1 comment
Assignees

Comments

Copy link
Collaborator

robertandremitchell commented Nov 20, 2024

Description:

Once work is complete to add query_data and conditions_list to the query table in the database, we will need to refactor this section of code: https://github.com/CDCgov/dibbs-query-connector/blob/main/query-connector/src/app/database-service.ts#L622

We should be able to avoid as many joins and just pull data from query. This may require updating the interface to not pull from valuesets or to reflect the JSON we create for query_data.

This should allow us to also in the case of superadmins get rid of any WHEREs. which only exist now to speed up processing. The limiting factor should be done based on user permissions, which we may need to add here or could potentially be accomplished in an alternative method.

Acceptance Criteria:

  • Fetches valuesets / concepts for conditions pulls from the query_data column
  • My Queries table pulls from the query table rather than hardcoded
  • Constants that tie the demo query options to labels / values / etc aren't so duplicative
Copy link

linear bot commented Nov 20, 2024

@fzhao99 fzhao99 self-assigned this Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants