Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding action to post artifact #90

Merged
merged 4 commits into from
Oct 25, 2024
Merged

Adding action to post artifact #90

merged 4 commits into from
Oct 25, 2024

Conversation

gvegayon
Copy link
Member

This pull request updates the GitHub Actions workflow for building and deploying the pkgdown site. The most important changes include adding permissions for pull requests, saving artifacts, and posting artifacts to pull requests.

Enhancements to GitHub Actions workflow:

@gvegayon gvegayon linked an issue Oct 23, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Oct 23, 2024

Thank you for your contribution @zsusswein 🚀! Your pkgdown-site is ready for download 👉 here 👈!
(The artifact expires on 2024-11-01T13:34:03Z. You can re-generate it by re-running the workflow here.)

@gvegayon gvegayon requested a review from zsusswein October 23, 2024 21:21
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Additional details and impacted files

📢 Thoughts on this report? Let us know!

@gvegayon gvegayon marked this pull request as ready for review October 23, 2024 21:22
@zsusswein
Copy link
Collaborator

As part of this issue, it would be good to fix the broken bullet point rendering in the pkgdown website. It looks fine in the readme rendering, so it's a good test-case of what this can prevent in the future.

The issue has this task listed too. Is that something you'd be able to add here?

See this on the website:

image

@gvegayon
Copy link
Member Author

gvegayon commented Oct 24, 2024

I think fd5453e fixes the broken bullet. Also, the mermaid diagram is not rendering properly, but that is something I would address in a separate PR as it needs more coding.

@zsusswein zsusswein enabled auto-merge (squash) October 25, 2024 13:30
@zsusswein zsusswein force-pushed the 52-preview-pkgdown-in-pr branch from fd5453e to 2b34a24 Compare October 25, 2024 13:32
@zsusswein zsusswein merged commit 338f0ec into main Oct 25, 2024
9 checks passed
@zsusswein zsusswein deleted the 52-preview-pkgdown-in-pr branch October 25, 2024 13:34
jkislin pushed a commit that referenced this pull request Nov 5, 2024
* Adding action to post artifact

* Forgot to add path

* Forgot to update news

* Fixing enum
jkislin pushed a commit that referenced this pull request Nov 5, 2024
* Adding action to post artifact

* Forgot to add path

* Forgot to update news

* Fixing enum
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Preview pkgdown in PR
2 participants