Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kg modify azure blob interface #8

Closed
wants to merge 6 commits into from

Conversation

kgostic
Copy link
Collaborator

@kgostic kgostic commented Aug 13, 2024

Will not merge

This proposes some changes and additions to #5. The plan is to move these functions and continue developing as a standalone package in R/azure.R and R/azure-setup.R over into a standalone package: https://github.com/CDCgov/cfazuR so that they can be used in other workflows.

Major edits:

  1. Added functions in R/azure_setup.R to set the required az credentials as env vars, load the credentials as a list from env var, and validate the list.
  2. Drafted tests to accompany R/azure_setup.R
  3. Outlined other functions needed so that each step in the process of authentication and connection to a blob endpoint is modular and throws informative errors on failure

Reasons this is still a draft

  • Need to document the required input format and explain how to set az credentials
  • Functions, documentation, and tests are rough drafts. I can't guarantee these will work well, build as a package, or render properly
  • Still need to write tests for az_get_env_credentials()

@natemcintosh -- let's talk about the order of operations for moving this all over into the new repo.

zsusswein and others added 6 commits August 7, 2024 18:55
Because of weird bug where render was breaking with error:

ℹ Loading CFAEpiNow2Pipeline
Error in `precommit::roxygenize_with_cache()`:
! The packages "AzureRMR" and "AzureStor" are required.
Backtrace:
    ▆
 1. └─precommit::roxygenize_with_cache(key = wd, dirs = path_relative_cache)
 2.   └─rlang::abort(conditionMessage(out)) at repo_114h0o4/R/roxygen2.R:103:5
Execution halted
Co-authored-by: Nate McIntosh <[email protected]>
Co-authored-by: Nate McIntosh <[email protected]>
@kgostic kgostic requested a review from natemcintosh August 13, 2024 17:51
@zsusswein
Copy link
Collaborator

Deprecated by https://github.com/CDCgov/cfazuR

@zsusswein zsusswein closed this Aug 26, 2024
@zsusswein zsusswein deleted the kg-modify-azure-blob-interface branch August 26, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants