Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Point to production environment #87

Open
gvegayon opened this issue Oct 16, 2024 · 4 comments · May be fixed by #158
Open

Point to production environment #87

gvegayon opened this issue Oct 16, 2024 · 4 comments · May be fixed by #158
Labels
CI/CD v0.1.0

Comments

@gvegayon
Copy link
Member

gvegayon commented Oct 16, 2024 •
edited by zsusswein
Loading

Image tag for pool

This needs to be fixed: right now, it is pointing to test-[branch name], it should just be [branch-name].

cfa-epinow2-pipeline/.github/workflows/containers-and-az-pool.yaml

Line 118 in b859765

${{ env.REGISTRY}}/${{ env.IMAGE_NAME }}:test-${{ needs.build-dependencies-image.outputs.tag }}

Output storage container

Currently it's zs-test-pipeline-update

EDIT 2024-12-11: Expanded to track general pipeline updates to move to production
@gvegayon gvegayon added bug Something isn't working CI/CD labels Oct 16, 2024
@zsusswein
Copy link
Collaborator

This was on purpose! We tag our current production pipeline with that tag. The test- prefix is to avoid overwriting that version.

@gvegayon
Copy link
Member Author

Isn't the production tag latest or prod?

@zsusswein
Copy link
Collaborator

The production tag is latest. For production we currently use the version of the pipeline in cdcent. We'd like to switch over to this version soon, but haven't yet. Because we haven't switched over we don't want to overwrite the prod latest tag.

@gvegayon
Copy link
Member Author

I'll leave this issue open so we remember that this needs to be changed once it goes into production.

@gvegayon gvegayon pinned this issue Oct 17, 2024
@zsusswein zsusswein added v0.1.0 and removed bug Something isn't working labels Oct 17, 2024
@zsusswein zsusswein changed the title Az registry pointing to the wrong tag Point Azure registry to production tag Oct 17, 2024
@zsusswein zsusswein mentioned this issue Dec 11, 2024
Merged
@zsusswein zsusswein changed the title Point Azure registry to production tag Point to production environment Dec 11, 2024
@zsusswein zsusswein mentioned this issue Jan 13, 2025
Open
@micahwiesner67 micahwiesner67 unpinned this issue Jan 14, 2025
@zsusswein zsusswein linked a pull request Jan 15, 2025 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CI/CD v0.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Drop test prefix CDCgov/cfa-epinow2-pipeline
2 participants
@gvegayon @zsusswein