generated from CDCgov/template
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consistency in geo_value
or state_abb
or group
#120
Comments
What does this mean? |
How's that? |
This is good and I have the same issue further up. I think |
Agreed that |
Agreed on |
Sounds to me like we are agreed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The data reading functions alternating between calling the geographic groups
geo_value
,state_abb
, or simply group.We need to pick one name and use it consistently. This change will also have the convenient side effect of allowing us to write a good definition once and @ inheritParams it.
@kgostic @natemcintosh any preferences here?
The text was updated successfully, but these errors were encountered: