Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistency in geo_value or state_abb or group #120

Open
Tracked by #69
zsusswein opened this issue Dec 11, 2024 · 6 comments
Open
Tracked by #69

Consistency in geo_value or state_abb or group #120

zsusswein opened this issue Dec 11, 2024 · 6 comments

Comments

@zsusswein
Copy link
Collaborator

zsusswein commented Dec 11, 2024

The data reading functions alternating between calling the geographic groups geo_value, state_abb, or simply group.

We need to pick one name and use it consistently. This change will also have the convenient side effect of allowing us to write a good definition once and @ inheritParams it.

@kgostic @natemcintosh any preferences here?

@athowes
Copy link
Collaborator

athowes commented Dec 11, 2024

What does this mean?

@zsusswein
Copy link
Collaborator Author

How's that?

@athowes
Copy link
Collaborator

athowes commented Dec 11, 2024

This is good and I have the same issue further up. I think geo_value is better. The "US" is not a state abbreviation.

@zsusswein
Copy link
Collaborator Author

Agreed that geo_value is my preferred answer

@natemcintosh
Copy link
Collaborator

Agreed on geo_value

@athowes
Copy link
Collaborator

athowes commented Dec 13, 2024

Sounds to me like we are agreed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants