added default db params to dev file (fix)

[arinkulshi-skylight]

Description

Docker is not connecting to DB anymore. db params are updated to ensure db connection works.

Checklist

• The title of this PR is descriptive and concise.
• My changes follow the style guidelines of this project.
• I have added or updated test cases to cover my changes.
• I've let the team know about this PR by linking it in the review channel

[jonchang]

While this fixes the issue I don't think this is the desired behavior? I think the idea behind the change to begin with was to ensure that when deployed, it would get these values from the environment. Whereas on a local dev build, it should have default values since the azure environment doesn't exist and won't be supplying those values.

[jonchang]

% docker compose -f dev-env.yaml up
invalid interpolation format for services.db.environment.POSTGRES_DB.
You may need to escape any $ with another $.
${postgres_db_name:reportvision}

This seems to fix it. I believe it uses bash parameter expansion? https://www.gnu.org/software/bash/manual/html_node/Shell-Parameter-Expansion.html

diff --git a/dev-env.yaml b/dev-env.yaml
index 14b607e..c384393 100644
--- a/dev-env.yaml
+++ b/dev-env.yaml
@@ -31,12 +31,12 @@ services:
     ports:
       - "5432:5432"
     environment:
-      POSTGRES_DB: ${postgres_db_name:reportvision}
-      POSTGRES_HOST: ${postgres_fqdn:localhost}
-      POSTGRES_USER: ${postgres_user:postgres}
-      POSTGRES_PASSWORD: ${postgres_password:super_secret_password}
-      DB_PORT: ${postgres_port:5432}
-      SSL_MODE: ${postgres_sslmode:disable}
+      POSTGRES_DB: ${postgres_db_name:-reportvision}
+      POSTGRES_HOST: ${postgres_fqdn:-localhost}
+      POSTGRES_USER: ${postgres_user:-postgres}
+      POSTGRES_PASSWORD: ${postgres_password:-super_secret_password}
+      DB_PORT: ${postgres_port:-5432}
+      SSL_MODE: ${postgres_sslmode:-disable}
   api:
     build: 
       context: ./backend

[arinkulshi-skylight]

% docker compose -f dev-env.yaml up
invalid interpolation format for services.db.environment.POSTGRES_DB.
You may need to escape any $ with another $.
${postgres_db_name:reportvision}

This seems to fix it. I believe it uses bash parameter expansion? https://www.gnu.org/software/bash/manual/html_node/Shell-Parameter-Expansion.html

diff --git a/dev-env.yaml b/dev-env.yaml
index 14b607e..c384393 100644
--- a/dev-env.yaml
+++ b/dev-env.yaml
@@ -31,12 +31,12 @@ services:
     ports:
       - "5432:5432"
     environment:
-      POSTGRES_DB: ${postgres_db_name:reportvision}
-      POSTGRES_HOST: ${postgres_fqdn:localhost}
-      POSTGRES_USER: ${postgres_user:postgres}
-      POSTGRES_PASSWORD: ${postgres_password:super_secret_password}
-      DB_PORT: ${postgres_port:5432}
-      SSL_MODE: ${postgres_sslmode:disable}
+      POSTGRES_DB: ${postgres_db_name:-reportvision}
+      POSTGRES_HOST: ${postgres_fqdn:-localhost}
+      POSTGRES_USER: ${postgres_user:-postgres}
+      POSTGRES_PASSWORD: ${postgres_password:-super_secret_password}
+      DB_PORT: ${postgres_port:-5432}
+      SSL_MODE: ${postgres_sslmode:-disable}
   api:
     build: 
       context: ./backend

You are right looks like I was using the springboot synthax here. I have made those changes.

[marycrawford]

Do we want to enable ssl_mode to enforce SSL encryption for this connection?

[arinkulshi-skylight]

I was thinking we can pass SSL_MODE as a argument(enabled,disabled) but kept it disabled by default for connecting to local host. Would this work?

[marycrawford]

It appears @jonchang and @derekadombek have tested this in the dev-env.yaml and application.yaml as disabled. SSL_MODE enabled adds additional security. However, I will defer to the majority decision of the team on whether it should be enabled at this time or before we hand it off.

[arinkulshi-skylight]

ok we can set it as enabled by default then.

[jonchang]

@derekadombek and i tested this in a pairing session today and we found that this was one of the changes needed to get the middleware container image to be able to talk to the database container image when running locally in docker compose. (There may be other changes needed as well, I need to see if I can replicate it locally)

Suggested change

	url: jdbc:postgresql://${POSTGRES_HOST:localhost}:${DB_PORT:5432}/${POSTGRES_DB:reportvision}?sslmode=${SSL_MODE:disable}
	url: jdbc:postgresql://${POSTGRES_HOST:db}:${DB_PORT:5432}/${POSTGRES_DB:reportvision}?sslmode=${SSL_MODE:disable}

[derekadombek]

In this PR we might want to add ENTRYPOINT [ "./gradlew", "bootRun", "--continuous", "--args=--server.port=8081" ] to the Dockerfile because right now that command is only being used in docker-compose.

[arinkulshi-skylight]

In this PR we might want to add ENTRYPOINT [ "./gradlew", "bootRun", "--continuous", "--args=--server.port=8081" ] to the Dockerfile because right now that command is only being used in docker-compose.

I added it to the dev-dockerfile as well. Now it is in both places. Let me know if this makes sense or if want me to also remove it from the docker compose file.

[derekadombek]

In this PR we might want to add ENTRYPOINT [ "./gradlew", "bootRun", "--continuous", "--args=--server.port=8081" ] to the Dockerfile because right now that command is only being used in docker-compose.

I added it to the dev-dockerfile as well. Now it is in both places. Let me know if this makes sense or if want me to also remove it from the docker compose file.

I might have to change it more in the Dockerfile later on once more connections are in place but yeah its better to have the command in the dockerfile itself since not all systems use docker-compose commands.

[marycrawford]

Does it matter if the dev-env.yaml is using :-name and the application.yaml file is not? For example, POSTGRES_DB: ${postgres_db_name:-reportvision} in the dev-env.yaml and name: ${POSTGRES_DB:postgres_db_name} in the name: ${POSTGRES_DB:postgres_db_name}.

[arinkulshi-skylight]

It seems one is springboot synthax and the other is bash synthax. app.yaml is being used locally so it should work as is.