Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the Mock API calls for Login and Student API calls #80

Closed
wants to merge 9 commits into from

Conversation

Rohitgour03
Copy link
Contributor

Add the Mock API calls for Login and Student API calls.

@gowtham3105
Copy link
Contributor

Create a separate folder for student and keep a file in it and add these student mocks in that. Similarly separate one for login. And then import then here. That will be a good coding style.

@gowtham3105
Copy link
Contributor

Also create const variables for large responses and define then in the starting. That will make the code looks good.

src/mocks/handlers.js Outdated Show resolved Hide resolved
src/mocks/handlers.js Outdated Show resolved Hide resolved
src/mocks/handlers.js Outdated Show resolved Hide resolved
offers: [{
designation: "Software Developer",
company_name: "Make My Trip",
application_id: "LLW4STE76GEJYOR",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See that this application I’d is also returned in getDashboard

@karthikmurakonda karthikmurakonda linked an issue Jun 4, 2022 that may be closed by this pull request
@gowtham3105
Copy link
Contributor

Did u try running these mocks? @Rohitgour03

@gowtham3105
Copy link
Contributor

like I'm seeing some naming differences
like placements is shown as placementsDetails
check it once try running it and make a video of it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API Mocks - Student, Login
3 participants