From 03cf272dc22fa79ad8901d8fc474f4ebd9b71b33 Mon Sep 17 00:00:00 2001 From: machadoum Date: Tue, 15 Oct 2024 15:07:33 +0200 Subject: [PATCH] Remove traces of asset criticality settings from cypress tests --- .../e2e/entity_analytics/asset_criticality_upload_page.cy.ts | 2 -- .../cypress/e2e/entity_analytics/entity_flyout.cy.ts | 2 -- .../cypress/tasks/api_calls/kibana_advanced_settings.ts | 5 ----- 3 files changed, 9 deletions(-) diff --git a/x-pack/test/security_solution_cypress/cypress/e2e/entity_analytics/asset_criticality_upload_page.cy.ts b/x-pack/test/security_solution_cypress/cypress/e2e/entity_analytics/asset_criticality_upload_page.cy.ts index 097e2541f57f9..aa9885a951734 100644 --- a/x-pack/test/security_solution_cypress/cypress/e2e/entity_analytics/asset_criticality_upload_page.cy.ts +++ b/x-pack/test/security_solution_cypress/cypress/e2e/entity_analytics/asset_criticality_upload_page.cy.ts @@ -12,7 +12,6 @@ import { RESULT_STEP, VALID_LINES_MESSAGE, } from '../../screens/asset_criticality'; -import { enableAssetCriticality } from '../../tasks/api_calls/kibana_advanced_settings'; import { clickAssignButton, uploadAssetCriticalityFile } from '../../tasks/asset_criticality'; import { login } from '../../tasks/login'; import { visit } from '../../tasks/navigation'; @@ -26,7 +25,6 @@ describe( () => { beforeEach(() => { login(); - enableAssetCriticality(); visit(ENTITY_ANALYTICS_ASSET_CRITICALITY_URL); }); diff --git a/x-pack/test/security_solution_cypress/cypress/e2e/entity_analytics/entity_flyout.cy.ts b/x-pack/test/security_solution_cypress/cypress/e2e/entity_analytics/entity_flyout.cy.ts index 976e68ba1bbc1..a65d7ddb6371a 100644 --- a/x-pack/test/security_solution_cypress/cypress/e2e/entity_analytics/entity_flyout.cy.ts +++ b/x-pack/test/security_solution_cypress/cypress/e2e/entity_analytics/entity_flyout.cy.ts @@ -42,7 +42,6 @@ import { ENTRA_DOCUMENT_TAB, OKTA_DOCUMENT_TAB, } from '../../screens/users/flyout_asset_panel'; -import { enableAssetCriticality } from '../../tasks/api_calls/kibana_advanced_settings'; const USER_NAME = 'user1'; const SIEM_KIBANA_HOST_NAME = 'Host-fwarau82er'; @@ -66,7 +65,6 @@ describe( cy.task('esArchiverLoad', { archiveName: 'risk_scores_new_complete_data' }); cy.task('esArchiverLoad', { archiveName: 'query_alert', useCreate: true, docsOnly: true }); cy.task('esArchiverLoad', { archiveName: 'user_managed_data' }); - enableAssetCriticality(); mockRiskEngineEnabled(); login(); visitWithTimeRange(ALERTS_URL); diff --git a/x-pack/test/security_solution_cypress/cypress/tasks/api_calls/kibana_advanced_settings.ts b/x-pack/test/security_solution_cypress/cypress/tasks/api_calls/kibana_advanced_settings.ts index 7307fa2418b68..09735e45ee4e4 100644 --- a/x-pack/test/security_solution_cypress/cypress/tasks/api_calls/kibana_advanced_settings.ts +++ b/x-pack/test/security_solution_cypress/cypress/tasks/api_calls/kibana_advanced_settings.ts @@ -6,7 +6,6 @@ */ import { SECURITY_SOLUTION_SHOW_RELATED_INTEGRATIONS_ID } from '@kbn/management-settings-ids'; -import { ENABLE_ASSET_CRITICALITY_SETTING } from '@kbn/security-solution-plugin/common/constants'; import { rootRequest } from './common'; export const setKibanaSetting = (key: string, value: boolean | number | string) => { @@ -24,7 +23,3 @@ export const enableRelatedIntegrations = () => { export const disableRelatedIntegrations = () => { setKibanaSetting(SECURITY_SOLUTION_SHOW_RELATED_INTEGRATIONS_ID, false); }; - -export const enableAssetCriticality = () => { - setKibanaSetting(ENABLE_ASSET_CRITICALITY_SETTING, true); -};