Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Due to problems with lineage graph, get_latest_roots sometimes includes non-current IDs #141

Open
ilexaquifolium opened this issue Jan 17, 2024 · 0 comments

Comments

@ilexaquifolium
Copy link

https://github.com/seung-lab/CAVEclient/blob/1e4fbbcfa357ea0719c186666a5a39393a949733/caveclient/chunkedgraph.py#L1012
https://github.com/seung-lab/CAVEclient/blob/1e4fbbcfa357ea0719c186666a5a39393a949733/caveclient/chunkedgraph.py#L1024
In some cases where a change has been made to a non-current version of the neuron, IDs that are not current IDs can be returned by get_latest_roots(). Example:

>>> client = caveclient.CAVEclient('fanc_production_mar2021')
>>> roots = client.chunkedgraph.get_latest_roots(648518346511326005)
>>> roots
array([648518346490738685, 648518346490090970, 648518346487824596,
       648518346478115029, 648518346491690920, 648518346493870449,
       648518346494682679, 648518346496428629, 648518346486444448,
       648518346467095022, 648518346504152360, 648518346494330759,
       648518346499567451])
>>> client.chunkedgraph.is_latest_roots(roots)
array([ True,  True,  True,  True,  True,  True, False,  True,  True,
       False,  True,  True,  True])

this can lead to suggest_latest_roots() also suggesting an ID that is not current:

>>> client.chunkedgraph.suggest_latest_roots(648518346511326005)
648518346494682679
>>> client.chunkedgraph.is_latest_roots(648518346494682679)
array([False])

Please find my pull request for a fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant