Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Off-by-one SampleID? #11

Open
luizirber opened this issue Feb 26, 2020 · 0 comments
Open

Off-by-one SampleID? #11

luizirber opened this issue Feb 26, 2020 · 0 comments
Assignees

Comments

@luizirber
Copy link

Hello,

I ran the opal_workflow.py script from OPAL with the sourmash biobox from #10 and the cami_ii_mg configs from the OPAL repo, but in the end the @SampleID were off-by-one (for sample_0 in the config file it had @SampleID:1 in the all_results.profile file). Is seems like the gold standard is counting from 0 (matching the filename), should it be counting from 1 to match the opal_workflow.py output?

(I'm not sure if this is the right repo to post given that it was triggered by OPAL, but the @SampleID issue seems to come from the Utils.pm script in this repo)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants