You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently if "Valid signatures only" is enabled, all unencrypted+unsigned mail will be rejected, regardless of the per-project activation setting. If you're validating signatures, you cannot have a project which is intended to receive unencrypted email (by leaving the OpenPGP module disabled on it) at the same time.
The decryption method should ideally be aware of the whether the OpenPGP module is enabled on the target project of the email.
Because of the odd order of operations and my lack of aptitude with Ruby on Rails, I'm not sure whether it could be implemented without modifying core. One issue is that the target_project is apparently not available at the time of MailHandler's receive operation, only afterward. So we need to patch the MailHandler to decrypt the email, check the signature, get the target project, then check that project's per-project activation setting, and finally determine whether to accept or reject the email.
The text was updated successfully, but these errors were encountered:
Notes:
The target_project seems to become accessible after running dispatch(), which then calls dispatch_to_default(), which simply calls receive_issue().
I'm using a global variable $invalid to store whether emails are valid between running the decryption module and checking the per-project settings in the new module. Don't know if there's a better way to do this.
Currently if "Valid signatures only" is enabled, all unencrypted+unsigned mail will be rejected, regardless of the per-project activation setting. If you're validating signatures, you cannot have a project which is intended to receive unencrypted email (by leaving the OpenPGP module disabled on it) at the same time.
The decryption method should ideally be aware of the whether the OpenPGP module is enabled on the target project of the email.
Because of the odd order of operations and my lack of aptitude with Ruby on Rails, I'm not sure whether it could be implemented without modifying core. One issue is that the
target_project
is apparently not available at the time of MailHandler's receive operation, only afterward. So we need to patch the MailHandler to decrypt the email, check the signature, get the target project, then check that project's per-project activation setting, and finally determine whether to accept or reject the email.The text was updated successfully, but these errors were encountered: