Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chemical renaming #59

Merged
merged 295 commits into from
Feb 8, 2024
Merged

Chemical renaming #59

merged 295 commits into from
Feb 8, 2024

Conversation

efmkoene
Copy link
Contributor

@efmkoene efmkoene commented Feb 5, 2024 •
edited by mjaehn
Loading

Fixes #37

This should eventually close #37 once async becomes the main code. It should push back into async (I've never pushed a branched branch, so please check if all goes correctly).

mjaehn and others added 30 commits December 20, 2023 11:57
@mjaehn
Use config instead of local variables
6dd552a
@mjaehn
Add logging for whole chain
7ec7bc1
GitHub Action: Apply Pep8-formatting
7c1a58d
@mjaehn
Add logging for jobs
59393b3
@mjaehn
Merge branch 'async' of github.com:C2SM/processing-chain into async
0c01df7
GitHub Action: Apply Pep8-formatting
d2fa410
@mjaehn
Small fix
47da701
GitHub Action: Apply Pep8-formatting
1c65c5b
@mjaehn
Format duration
b0dd12a
@mjaehn
Merge branch 'async' of github.com:C2SM/processing-chain into async
d2df141
@mjaehn
Remove --wait from submit function
54b21a6
@mjaehn
Let geosp be a separate job
5769f8a
GitHub Action: Apply Pep8-formatting
df4fb2c
@mjaehn
Add run_chain argument to process specified chunk
f9a8060
GitHub Action: Apply Pep8-formatting
bbad6e9
@mjaehn
Fix datetime comparison in int2lm
f6e75b3
@mjaehn
Merge branch 'async' of github.com:C2SM/processing-chain into async
a68b4ae
@mjaehn
Submit all jobs as sbatch
d885c39
GitHub Action: Apply Pep8-formatting
3181262
@mjaehn
Use existing submit() function and only return job_id
f1c757d
@mjaehn
Merge branch 'async' of github.com:C2SM/processing-chain into async
6661ce5
GitHub Action: Apply Pep8-formatting
bb8844f
@mjaehn
Fix prepare_data
0b5faf1
@mjaehn
Merge branch 'async' of github.com:C2SM/processing-chain into async
81047bf
@mjaehn
Disable logging for individual jobs
e64cd48
GitHub Action: Apply Pep8-formatting
efd94d6
@mjaehn
Write casename into logfile
6871eff
@mjaehn
Merge branch 'async' of github.com:C2SM/processing-chain into async
d7d8c08
@mjaehn
Fix timers for jobs
cee8c44
GitHub Action: Apply Pep8-formatting
f60cd9d
@mjaehn
Copy link
Contributor

mjaehn commented Feb 5, 2024

@efmkoene Thanks for this PR! I will review this one, but will set the base branch to v3.1-rc once async is merged (as it is in its final review stage).

mjaehn
mjaehn requested changes Feb 5, 2024
View reviewed changes
Copy link
Contributor

@mjaehn mjaehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to shorten the variable name.

cases/icon-art-oem-test/config.yaml Outdated Show resolved Hide resolved
jobs/prepare_art_oem.py Outdated Show resolved Hide resolved
@efmkoene
Copy link
Contributor Author

efmkoene commented Feb 5, 2024

This satisfies your review :-)

@mjaehn mjaehn linked an issue Feb 6, 2024 that may be closed by this pull request
De-hardcode chemical tracers work in prepare_data for ICON #37
Open
Base automatically changed from async to v3.1-rc February 7, 2024 08:54
@mjaehn
Copy link
Contributor

mjaehn commented Feb 7, 2024

launch jenkins

@mjaehn mjaehn merged commit 37a7363 into v3.1-rc Feb 8, 2024
2 checks passed
@mjaehn mjaehn deleted the chemical_renaming branch February 8, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjaehn mjaehn mjaehn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

De-hardcode chemical tracers work in prepare_data for ICON
3 participants
@efmkoene @mjaehn @leclairm