From ce5144bb2bac991453e55fac7e8190b992b0cda6 Mon Sep 17 00:00:00 2001 From: Alexander Goscinski Date: Thu, 12 Sep 2024 11:19:22 +0200 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Julian Geiger --- src/wcflow/wc/_classes.py | 4 ++-- src/wcflow/workgraph.py | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/wcflow/wc/_classes.py b/src/wcflow/wc/_classes.py index 9611f75..38e9da5 100644 --- a/src/wcflow/wc/_classes.py +++ b/src/wcflow/wc/_classes.py @@ -366,7 +366,7 @@ def _to_core_cycle(self, cycle: Cycle) -> core.Cycle: def _to_core_task(self, task: CycleTask) -> core.Task: inputs = [] outputs = [] - dependcies = [] + dependencies = [] for input_ in task.inputs: if (data := self._data.get(input_.name)) is None: msg = f"Task {task.name!r} has input {input_.name!r} that is not specied in the data section." @@ -381,7 +381,7 @@ def _to_core_task(self, task: CycleTask) -> core.Task: outputs.append(core_data) for depend in task.depends: core_dependency = core.Dependency(depend.task_name, depend.lag, depend.date, depend.cycle_name) - dependcies.append(core_dependency) + dependencies.append(core_dependency) return core.Task( task.name, diff --git a/src/wcflow/workgraph.py b/src/wcflow/workgraph.py index d616670..bc99a3e 100644 --- a/src/wcflow/workgraph.py +++ b/src/wcflow/workgraph.py @@ -96,7 +96,7 @@ def _validate_workflow(self): except ValueError as exception: msg = f"Raised error when validating input name '{input_.name}': {exception.args[0]}" raise ValueError(msg) from exception - for output in task.unrolled_inputs: + for output in task.unrolled_outputs: try: aiida.common.validate_link_label(task.name) except ValueError as exception: