-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In the preflight report include url pointed on the appropriate paragraph/cell in order to use the cell number JSON #206
Comments
In the workflow_dispatch in order to know the branch when the workflow is launched , need to use: As workflow can be run from branch also: The others didn't work for workflow_dispatch To point on the url https://journalofdigitalhistory.org/en/notebook-viewer/JTJGcHJveHktZ2l0aHVidXNlcmNvbnRlbnQlMkZDMkRIJTJGdGVtcGxhdGVfcmVwb19KREhfUiUyRm1hc3RlciUyRmF1dGhvcl9ndWlkZWxpbmVfdGVtcGxhdGUuaXB5bmI=?idx=7, need to encode the GitHub url by passing proxy_value = f'/proxy-githubusercontent/{username}/{repo}/{filepath}' Docs here about GitHub context |
problem by testing due to C2DH/journal-of-digital-history#581 |
Ex: No valid tags found for image output in cell 7
https://github.com/C2DH/template_repo_JDH_R/blob/master/report.md
doesn't make sense for the author as it's the cell number json
need to include the url like this:
https://github.com/C2DH/template_repo_JDH_R/blob/master/author_guideline_template.ipynb
https://journalofdigitalhistory.org/en/notebook-viewer/JTJGcHJveHktZ2l0aHVidXNlcmNvbnRlbnQlMkZDMkRIJTJGdGVtcGxhdGVfcmVwb19KREhfUiUyRm1hc3RlciUyRmF1dGhvcl9ndWlkZWxpbmVfdGVtcGxhdGUuaXB5bmI=?idx=7
The text was updated successfully, but these errors were encountered: