Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In the preflight report include url pointed on the appropriate paragraph/cell in order to use the cell number JSON #206

Open
eliselavy opened this issue Sep 28, 2023 · 2 comments
Assignees

Comments

@eliselavy
Copy link
Collaborator

Ex: No valid tags found for image output in cell 7
https://github.com/C2DH/template_repo_JDH_R/blob/master/report.md

doesn't make sense for the author as it's the cell number json

need to include the url like this:
https://github.com/C2DH/template_repo_JDH_R/blob/master/author_guideline_template.ipynb

https://journalofdigitalhistory.org/en/notebook-viewer/JTJGcHJveHktZ2l0aHVidXNlcmNvbnRlbnQlMkZDMkRIJTJGdGVtcGxhdGVfcmVwb19KREhfUiUyRm1hc3RlciUyRmF1dGhvcl9ndWlkZWxpbmVfdGVtcGxhdGUuaXB5bmI=?idx=7

@eliselavy eliselavy self-assigned this Sep 28, 2023
eliselavy added a commit to C2DH/journal-of-digital-history-ipynb-preflight-action that referenced this issue Oct 3, 2023
@eliselavy
Copy link
Collaborator Author

eliselavy commented Oct 3, 2023

In the workflow_dispatch in order to know the branch when the workflow is launched , need to use:github.ref

As workflow can be run from branch also:
Screenshot 2023-10-03 at 18 25 07

The others didn't work for workflow_dispatch
Screenshot 2023-10-03 at 17 13 25

To point on the url https://journalofdigitalhistory.org/en/notebook-viewer/JTJGcHJveHktZ2l0aHVidXNlcmNvbnRlbnQlMkZDMkRIJTJGdGVtcGxhdGVfcmVwb19KREhfUiUyRm1hc3RlciUyRmF1dGhvcl9ndWlkZWxpbmVfdGVtcGxhdGUuaXB5bmI=?idx=7, need to encode the GitHub url by passing proxy_value = f'/proxy-githubusercontent/{username}/{repo}/{filepath}'

Docs here about GitHub context
https://docs.github.com/en/actions/learn-github-actions/contexts#github-context

eliselavy added a commit to C2DH/journal-of-digital-history-ipynb-preflight-action that referenced this issue Oct 4, 2023
eliselavy added a commit to C2DH/journal-of-digital-history-ipynb-preflight-action that referenced this issue Oct 11, 2023
@eliselavy
Copy link
Collaborator Author

problem by testing due to C2DH/journal-of-digital-history#581

eliselavy added a commit to C2DH/journal-of-digital-history-ipynb-preflight-action that referenced this issue Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant