Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Technical review after R1 Chinese Political and Cultural Elites: Twentieth Century Transformations #182

Closed
eliselavy opened this issue Sep 12, 2024 · 18 comments
Assignees

Comments

@eliselavy
Copy link
Collaborator

https://github.com/jdh-observer/JMU8e6tFQscz

eliselavy added a commit to jdh-observer/JMU8e6tFQscz that referenced this issue Sep 12, 2024
eliselavy added a commit to jdh-observer/JMU8e6tFQscz that referenced this issue Sep 12, 2024
eliselavy added a commit to jdh-observer/JMU8e6tFQscz that referenced this issue Sep 12, 2024
@eliselavy
Copy link
Collaborator Author

@biumiamy same problem here , some figures are 46MB, can you look at in the media folder

Branch revision
https://github.com/jdh-observer/JMU8e6tFQscz/tree/revision

@biumiamy
Copy link
Collaborator

biumiamy commented Sep 13, 2024

Editorial point: figure 6 is not very well readable. Finally a lightbox would be useful..

2024-09-13 10_24_51-Journal of Digital History

@biumiamy
Copy link
Collaborator

biumiamy commented Sep 13, 2024

And for design review later: italic sections that are quotes -> add ">" for blockquote style

2024-09-13 10_42_42-Journal of Digital History

@eliselavy
Copy link
Collaborator Author

Editorial point: figure 6 is not very well readable. Finally a lightbox would be useful..

2024-09-13 10_24_51-Journal of Digital History

@biumiamy do you try the skim?

@biumiamy
Copy link
Collaborator

Ah but this is unrelated to the skim.. It's about how the figure was designed from scratch. It's crazy long vertically. If it was horizontal, it would be better perhaps

@eliselavy
Copy link
Collaborator Author

@biumiamy same problem here , some figures are 46MB, can you look at in the media folder

Branch revision https://github.com/jdh-observer/JMU8e6tFQscz/tree/revision

@biumiamy i see your figures branch but not started from revisions

@biumiamy
Copy link
Collaborator

Okay, I added it to the revision branch:
jdh-observer/JMU8e6tFQscz@83c0443

@eliselavy
Copy link
Collaborator Author

Okay, I added it to the revision branch: jdh-observer/JMU8e6tFQscz@83c0443

do you not rename it without . in it as made for previous article, see here:
#163 (comment)

same remark also , if we no more use png, in R find only this solution for the Jupyter notebook , need to be validated #163 (comment)

otherwise need to keep png

@biumiamy
Copy link
Collaborator

ah. no problem I can do png. but the total size will be bigger for the notebook then

@eliselavy
Copy link
Collaborator Author

eliselavy commented Sep 23, 2024

ah. no problem I can do png. but the total size will be bigger for the notebook then

@biumiamy if the solution mentionned above is ok, we can fit with jpeg
tell me

@biumiamy
Copy link
Collaborator

I checked the other solution, it doesnt work. So need to keep png

@biumiamy
Copy link
Collaborator

updated to png: jdh-observer/JMU8e6tFQscz@master...revision

eliselavy added a commit to jdh-observer/JMU8e6tFQscz that referenced this issue Sep 24, 2024
eliselavy added a commit to jdh-observer/JMU8e6tFQscz that referenced this issue Sep 24, 2024
eliselavy added a commit to jdh-observer/JMU8e6tFQscz that referenced this issue Sep 24, 2024
@eliselavy
Copy link
Collaborator Author

updated to png: jdh-observer/[email protected]

@biumiamy code updated / run notebook / reconvert table in html now notebook has a good size 6.78 MB
can you check the anchor, can be updated in the md file

eliselavy added a commit to jdh-observer/JMU8e6tFQscz that referenced this issue Sep 24, 2024
@biumiamy
Copy link
Collaborator

added anchors and corrected American to British English:
jdh-observer/JMU8e6tFQscz#2

@eliselavy
Copy link
Collaborator Author

Screenshot 2024-09-25 at 11 59 10

eliselavy added a commit to jdh-observer/JMU8e6tFQscz that referenced this issue Sep 25, 2024
@eliselavy
Copy link
Collaborator Author

eliselavy commented Sep 25, 2024

Screenshot 2024-09-25 at 11 59 10

@biumiamy i merged also but this text should not be, can you correct and transform also table-10 in html in Markdown (uses AI)
Screenshot 2024-09-25 at 12 00 17

eliselavy added a commit to jdh-observer/JMU8e6tFQscz that referenced this issue Sep 26, 2024
@eliselavy
Copy link
Collaborator Author

Screenshot 2024-09-25 at 11 59 10

@biumiamy i merged also but this text should not be, can you correct and transform also table-10 in html in Markdown (uses AI) Screenshot 2024-09-25 at 12 00 17

done

@eliselavy
Copy link
Collaborator Author

@inactinique to be sent to PEER-REVIEW

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants