Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seems to break on all screens above 1080p #10

Open
MrCollinsR opened this issue Jun 13, 2022 · 4 comments
Open

Seems to break on all screens above 1080p #10

MrCollinsR opened this issue Jun 13, 2022 · 4 comments

Comments

@MrCollinsR
Copy link

Tested the Demo on 4 computers:
M1 Macbook Pro: Cuts off capture
2020 Macbook Pro: Cuts off Capture
Dell XPS 4k: Cuts off capture
Gaming Rig 1080p: Works perfectly.

In the below image i captured the entire box but as you can see the capture that gets saved is just a fraction of that.
image

It appears that when your resolution is higher than 1080p the capture has the wrong resolution so it only records a portion of what you are trying to capture. I have seen the same behavior on other react screen cap libraries so I believe the issue is in the core library that has likely been forked. However i haven't had a chance to deep dive yet.

@vyemialyanchyk
Copy link

I can confirm the problem exist - in case if screen resolution bigger than 1080 Capture does not capture selected region correctly...

@vyemialyanchyk
Copy link

reproducible on live demo example

@vyemialyanchyk
Copy link

vyemialyanchyk commented Feb 19, 2023

after small research the problem related with window.devicePixelRatio
in case if I make screen resolution so window.devicePixelRatio := 1 - capture works correctly
but with maximum screen resolution 3840 x 2160 when window.devicePixelRatio := 1.5 - capture works incorrectly..

vyemialyanchyk pushed a commit to vyemialyanchyk/react-screen-capture that referenced this issue Feb 19, 2023
@vyemialyanchyk
Copy link

#14 - this is fix for the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants