-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: Angular import paths are incorrect with child components #1205
Comments
This is the code that generates Mitosis component imports: mitosis/packages/core/src/helpers/render-imports.ts Lines 154 to 161 in a3d65ca
We actually have an mitosis/packages/core/src/generators/angular.ts Lines 464 to 471 in a3d65ca
Easiest way would be to set a default value for
So that it imports the correct thing (depending on whether |
I am interested in helping provide a fix!
Yes
Which generators are impacted?
Reproduction case
https://mitosis.builder.io/?outputTab=IYOw5grgNsBOQ%3D%3D%3D&code=JYWwDg9gTgLgBAbzgVwM4FMDKMCGN1wC%2BcAZlBCHAEQACARssADYAm6UAdMBAPQjAwIqYKioBuAFATQkWIjgBhABbMWCipAB26TfGJkKcAOQceAYxWsjkiegAes%2BGxI5kTeCWSazMbprgAsgCe6uAQ2roAFGDkYKgAlIgScHBm4ajwANqaOCDoADRwGDAAcrnoALpwALwoGNh46JFU2OgAbuhU8TYpUOgwyFD%2BkckpcAA8LMBtAHyjYxPAmmDIMPMLqaio1QgI6xupEEzQAFzUfSxU%2BftjhIQ3KW04TMjoOzl59wcp4co4mgBzN4ISLtHQwRLVGZFfplPKgjq6Di4KBAmAcJ4vdDxL4bHhzA7jZSqUJacFwfE3AAS6CYxwAhHAAJKpf5wKBeOBLOAAJXQOB8hQAaq9CpgjsAWIVoHAADLAACOjBY9PW4x4U1mo26EkIQA%3D%3D%3D
Expected Behaviour
An additional import statement (or the existing one replaced) should import the generated module of the component, instead of the component class.
Actual Behaviour
The generated output is missing a necessary import for the Angular module:
ChildComponentModule
is not imported in the generated output.Additional Information
Angular standalone components could be a solid replacement for modules to simplify the generated output.
The text was updated successfully, but these errors were encountered: