Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review spacing in some edge case resolutions (1024px to 1300ish px width) #63

Closed
Pabl0cks opened this issue Mar 6, 2024 · 4 comments
Closed

Review spacing in some edge case resolutions (1024px to 1300ish px width) #63

Pabl0cks opened this issue Mar 6, 2024 · 4 comments

Comments

@Pabl0cks
Copy link
Member

Pabl0cks commented Mar 6, 2024

Probably fixing from 1024px to 1280px (lg breakpoint) may be enough if next breakpoint makes it look worse in bigger resolutions from the xl breakpoint.

1280px example

grants-1280width-small
@carletex
Copy link
Contributor

carletex commented Mar 6, 2024

Is it only for "completed grants"?

@Pabl0cks
Copy link
Member Author

Pabl0cks commented Mar 7, 2024

Is it only for "completed grants"?

Yep! Maybe other sections could have a little more spacing but not sure if they would look better or worse. So we can just set "completed grants" like they other ones and it would look balanced.

@carletex carletex mentioned this issue Mar 20, 2024
Merged
@carletex
Copy link
Contributor

Should be fixed at #84

leave this open until test (I yoloed the PR)

@Pabl0cks
Copy link
Member Author

Should be fixed at #84

I see it great now! TYSM! Closing 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@carletex @Pabl0cks