Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new item - AUCT - to the OTHER category on the Collections page #87

Open
emylonas opened this issue Feb 15, 2023 · 1 comment
Open
Assignees

Comments

@emylonas
Copy link
Contributor

Landing page, which displays a list of collections listed by state: usepigraphy.brown.edu
This page also has a second list, labelled "OTHER" right below the list of states at the top of the page. We would like to add a second type of non-state collection, whose label will be "AUCT" (stands for auction).

These lists are generated in the following file:
./usep_app/usep_templates/_site/collectionS.html

The state menus are handled starting on line 10, where the code iterates over the region codes from the Django database, but excludes the "ITA" code.
"ITA" is handled in the next section, starting at line 20.

I know this is a kludge, but can we have it exclude "AUCT" as well as "ITA" in the state section, and then add the "AUCT" check explicitly "ITA", probably after line 25.

Similarly, "AUCT" has to be added explicitly after "ITA" when the actual collections are listed, so it would go right before line 64. Again, checking for "AUCT" and listing collections that have that region code.

@birkin
Copy link
Member

birkin commented Mar 7, 2023

@emylonas -- i haven't looked at the code, but what you describe above sounds very reasonable. I just tentatively scheduled myself to work on this the week of Monday March 13.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants