Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Thrifty Nova from The ThriftyBot as a motor controller #221

Open
clrozeboom opened this issue Aug 25, 2024 · 3 comments
Open

Add Thrifty Nova from The ThriftyBot as a motor controller #221

clrozeboom opened this issue Aug 25, 2024 · 3 comments

Comments

@clrozeboom
Copy link
Contributor

I am working with Ryan Dognaux from The ThriftyBot and Team Thrifty to port their new Thrifty Nova motor controller to YAGSL so that teams will be able to use it before the 2025 build season. I currently have it at least able to use the code in simulation and am hoping to have hardware to test it with soon. Once I'm confident that it works correctly, I can push the implementation down.
I may also include a port of the API for the new Thrifty Encoder.

@thenetworkgrinch
Copy link
Contributor

thenetworkgrinch commented Aug 25, 2024

I am so excited for these new controllers and encoders!! Thank you so much for your work as usual! :)

@clrozeboom
Copy link
Contributor Author

Pushed some changes to you because I saw that others were also getting interested in implementing this. I'm also working on implementing the attached absolute encoder code (ThriftyNovaEncoderSwerve) but as you have noticed, they don't have encoder-wrapping yet, or offsets. I'm hoping I can get actual hardware soon and on a robot to test with. The new ThriftyEncoder wasn't in this release, yet, so that's on the back-burner until they add it to the published API.

@thenetworkgrinch
Copy link
Contributor

Thanks for the PR so far! I love their util functions. It looks like a really nice API thats only going to get better as the product advances! I cant wait to use them either!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants