Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ORGANISE THE CODE! #8

Open
Ethan-Stark opened this issue Sep 11, 2024 · 1 comment
Open

ORGANISE THE CODE! #8

Ethan-Stark opened this issue Sep 11, 2024 · 1 comment
Labels
next update This issue will be resolved in the next major update overhaul This issue is going to take a while to resolve

Comments

@Ethan-Stark
Copy link

Please organise the data better. It'll make future development so much easier.
Use classes for weapons and charms.
Don't use other imported file variables to hold values relevant to the current run. (you're using the imported files like you should use classes)
Also, avoid the heavy recursive function calling. Use a proper game loop, don't just call the same function over and over every new enemy, it could easily lead to weird and difficult to manage errors.
I can help with python classes and implementing them into the code, just don't use an imported file. (if not classes at least make some special dictionaries with functions and constant/regulated keys depending on the data needed)
Also ADD COMMENTS! It can be hard to follow with the excessive recursion, and your desired results must be guessed without them.

@Ethan-Stark
Copy link
Author

Type annotation wouldn't hurt

@Broclly Broclly added next update This issue will be resolved in the next major update overhaul This issue is going to take a while to resolve labels Sep 11, 2024
@Broclly Broclly moved this to Todo in Issue Tracking Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next update This issue will be resolved in the next major update overhaul This issue is going to take a while to resolve
Projects
Status: In Progress
Development

No branches or pull requests

2 participants