Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add latest ISL videos #258

Open
5 of 7 tasks
svishnu06 opened this issue Nov 19, 2024 · 4 comments
Open
5 of 7 tasks

Add latest ISL videos #258

svishnu06 opened this issue Nov 19, 2024 · 4 comments
Assignees
Labels

Comments

@svishnu06
Copy link
Contributor

svishnu06 commented Nov 19, 2024

ISL team keep adding to the list of videos as their bible is not completed.
Every few months on their request we take the backlog and add them to the list of already added videos by going through their YouTube channel.

  • create new script (3 hrs)
  • create csv and json files using scripts (2 hrs)
  • Add files to GitHub repo (1 hrs)
  • Code Review (30 min)
  • Add to staging(30 min)
  • QA
  • Add to Production
@svishnu06 svishnu06 self-assigned this Nov 19, 2024
@svishnu06
Copy link
Contributor Author

svishnu06 commented Nov 29, 2024

ISL video -
updated csv PR
updated json PR

newly added videos :-

lev: ['12', '13', '14', '15', '16', '17', '18', '19', '20', '21', '22', '23', '24', '25', '26', '27']
1sa: ['7', '9', '10', '11', '12', '13', '14', '15', '16', '17', '18', '19', '20', '21', '22', '23', '24', '26', '27', '28', '25', '29', '30', '31']
2sa: ['1', '2', '3', '4', '5', '6', '7', '8', '9', '10', '11']
psa: ['intro', '1', '2', '3', '4', '5', '6', '7', '8', '9', '10', '11', '12', '13', '14', '15', '16', '17', '18', '19', '20', '21', '22', '23', '24', '25', '26', '27', '28', '29', '30', '31', '32', '33', '34', '35', '36', '37', '38', '39', '40', '41', '42', '43', '44', '45', '46', '47', '48', '49', '50', '51', '52', '53', '54', '55', '56', '57', '58', '59', '60', '61', '62', '63', '64', '65', '66', '67', '68', '69', '70', '71', '72', '73', '74', '75']
pro: ['intro', '1', '2', '3', '4', '5', '6', '7', '8']
mal: ['3', '4']
luk: ['4']
1co: ['9', '10', '11', '12', '13', '14', '15', '16']
2co: ['1', '2', '3', '4', '5', '6', '7', '8', '9', '10', '11', '12', '13']
phi: ['intro', '1', '2', '3', '4']
col: ['intro', '1', '2', '3', '4']

@RevantCI
Copy link
Collaborator

RevantCI commented Dec 3, 2024

PR merged but some corrections required

  1. Remove old Luke 4 from csv and json - "url": "https://youtu.be/1P_zzMIvh7M"
  2. Philippians book code correction currently - 'phi' need to change in csv and json
  3. Add space in descriptions as some words joined together eg. PhilippiansAuthorshipApostle

@svishnu06
Copy link
Contributor Author

Philippians book code changed
Added space in descriptions

PR - ISL.csv
PR -ISL.json

@VineethaVi VineethaVi self-assigned this Dec 17, 2024
@VineethaVi
Copy link

Test Result : Pass

Tested for these videos:

  • lev: ['12', '13', '14', '15', '16', '17', '18', '19', '20', '21', '22', '23', '24', '25', '26', '27']
  • 1sa: ['7', '9', '10', '11', '12', '13', '14', '15', '16', '17', '18', '19', '20', '21', '22', '23', '24', '26', '27', '28', '25', '29', '30', '31']
  • 2sa: ['1', '2', '3', '4', '5', '6', '7', '8', '9', '10', '11']
  • psa: ['intro', '1', '2', '3', '4', '5', '6', '7', '8', '9', '10', '11', '12', '13', '14', '15', '16', '17', '18', '19', '20', '21', '22', '23', '24', '25', '26', '27', '28', '29', '30', '31', '32', '33', '34', '35', '36', '37', '38', '39', '40', '41', '42', '43', '44', '45', '46', '47', '48', '49', '50', '51', '52', '53', '54', '55', '56', '57', '58', '59', '60', '61', '62', '63', '64', '65', '66', '67', '68', '69', '70', '71', '72', '73', '74', '75']
  • pro: ['intro', '1', '2', '3', '4', '5', '6', '7', '8']
  • mal: ['3', '4']
  • luk: ['4']
  • 1co: ['9', '10', '11', '12', '13', '14', '15', '16']
  • 2co: ['1', '2', '3', '4', '5', '6', '7', '8', '9', '10', '11', '12', '13']
  • phi: ['intro', '1', '2', '3', '4']
  • col: ['intro', '1', '2', '3', '4']

All the listed ISL videos are tested and are functioning properly.

Testing Environment: https://www.dev.vachanonline.com/

Moving this issue to Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants