Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transitive Dependency: failure crate pulled in by prisma-client-rust 0.6.11 #473

Open
saisab29 opened this issue Jan 16, 2025 · 0 comments

Comments

@saisab29
Copy link

When using the prisma-client-rust crate with the 0.6.11 tag, it appears that the deprecated failure crate (version 0.1.8) is being pulled in as a transitive dependency. Since failure is no longer maintained and is known to have vulnerabilities, it would be beneficial to remove or replace it.

Observed Behavior:

The failure crate and its dependencies are downloaded and added to the project. This can be seen in the cargo tree output:

├── dml v0.1.0 (git+https://github.com/Brendonovich/prisma-engines?tag=pcr-0.6.10#c4aeef82dbae310e974d6122160c7e3b5fb6df53)
│   ├── cuid v0.5.1
│   │   ├── base36 v0.0.1
│   │   │   ├── failure v0.1.8


Expected Behavior

The failure crate should not be included, as it is deprecated and introduces potential security risks. If the crate is still being used, it should be replaced with modern alternatives like thiserror or anyhow.

Steps to Reproduce

  • Add the following to Cargo.toml (mentioned in the docs for prisma client rust)
    )
prisma-client-rust = { git = "https://github.com/Brendonovich/prisma-client-rust", tag = "0.6.11" }
prisma-client-rust-cli = { git = "https://github.com/Brendonovich/prisma-client-rust", tag = "0.6.11" }
  • Run cargo build or cargo tree to inspect dependencies.
  • Observe that the failure crate (v0.1.8) and its companion failure_derive are pulled in as transitive dependencies.

Environment

Rust version: [rustc 1.83.0]
prisma-client-rust tag: 0.6.11
OS: [Windows 11]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant