Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support cropping / region of interest #302

Open
Breakthrough opened this issue Nov 16, 2022 · 3 comments · May be fixed by #449
Open

Support cropping / region of interest #302

Breakthrough opened this issue Nov 16, 2022 · 3 comments · May be fixed by #449
Labels
Milestone

Comments

@Breakthrough
Copy link
Owner

Breakthrough commented Nov 16, 2022

Processing only a sub-set of a video frame should be possible. This can greatly improve performance and detection accuracy in some cases.

To avoid any issues with cropping or output, both save-images and split-video should still output the full video. Cropping of the output can be considered in the future, but should be avoided if possible and done by post-processing the output of PySceneDetect. The same applies to non-rectangular ROIs or overlapping regions.

This was originally brought up in #147. This is also a feature in PyVfxShotDetect [1], so we can consider implementing something similar by creating a wrapper for VideoStream.

[1] https://github.com/ThomasWeckenmann/PyVfxShotDetect/blob/master/scenedetect/bbox_video_stream.py

@ankandrew
Copy link

Looking forward this feature 🙏

@Breakthrough Breakthrough modified the milestones: 0.6.6, 0.6.5 Jun 16, 2024
@cdgraff
Copy link

cdgraff commented Jun 17, 2024

+1 will be amazing have this feature! I need too...

@Breakthrough Breakthrough linked a pull request Oct 25, 2024 that will close this issue
3 tasks
@Breakthrough
Copy link
Owner Author

Breakthrough commented Oct 26, 2024

Can anyone share if they require a GUI for this purpose, or is command line acceptable? cc @ankandrew @cdgraff

I'm thinking the regions can be a set of polygon masks similar to how DVR-Scan handles this. Similarily, if we need a GUI, I may repurpose the region editor from DVR-Scan for this purpose, since that has most of the required functionality. This also means we can support non-rectangular masks.

Regardless we should ship something soon and leave the GUI for later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants