Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Charm of Desires activates on respawn with Refightilzation #26

Open
EllieShrug opened this issue May 30, 2024 · 6 comments
Open

Charm of Desires activates on respawn with Refightilzation #26

EllieShrug opened this issue May 30, 2024 · 6 comments

Comments

@EllieShrug
Copy link

Refight lets players respawn as monsters, and every time we do Charm of Desires activates and gives us more essences. This can lead to insane snowballing in multiplayer. I am not certain how Refight's respawns work, but I find that mod very fun and would love for this mod to be 100% compatible without breaking balance because of the charm. We could choose to ignore them when essences spawn in this way, but that leads to large fps drops and maps being littered with little orbs.

Loving the mod otherwise though!

@BrandonRosa
Copy link
Owner

Huh, that's a funny interaction

I'll take a look at refightilization's code to see how I can work around it. Thanks for the report and I'm glad to know you're enjoying it!

@EllieShrug
Copy link
Author

Oh also I just remembered, the reducer can be used on the item displays in Bigger Bazaar, which is an incredibly popular mod and can also lead to this snowballing with essences. By displays I mean the things in the first image, maybe disabling it in bazaar, I am not sure how to fix that honestly.

@BrandonRosa
Copy link
Owner

Huh, I had no clue. Seems like an easy fix though. I'll just disable it's use in the bazaar when that mod is enabled. Thanks!

@EllieShrug
Copy link
Author

That could work, because honestly being able to just buy 15 essences with essentially zero consequences is probably more broken than a red item from that mod. Especially being able to buy up to three of them, randomly dropped reds actually make you consider if it should be reduced, but bigger bazaar trivialized that choice. But I did like turning some green scrap into a red with soups to convert to essences, so its a mixed bag fix. Eh, still more balanced with it just being disabled.

@BrandonRosa
Copy link
Owner

You could still reduce a red item, if you find a scraper after leaving though. So your game plan should be fine still! Either way I'll try my best to find a more elegant solution.

@EllieShrug
Copy link
Author

Whatever works best in your eyes is definitely better than the display items being converted into real items.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants