Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BranchStrongMatchHelper still references android.support.customtabs.* #25

Open
mattt-seek opened this issue Apr 8, 2021 · 1 comment

Comments

@mattt-seek
Copy link

Running the gradle plugin: canISayByeByeJetifier to determine if it is safe to turn off the Jetifier in our codebase (to optimise build time).
It throws up branch as problematic, due to the following references

 Graphs to this dependency:
 +---io.branch.sdk.android:library:5.0.7
 Issues found:
 * io/branch/referral/BranchStrongMatchHelper.class -> android.support.customtabs.CustomTabsClient
 * io/branch/referral/BranchStrongMatchHelper.class -> android.support.customtabs.CustomTabsCallback
 * io/branch/referral/BranchStrongMatchHelper.class -> android.support.customtabs.CustomTabsSession

Via the following code

{
        try {
            CustomTabsClientClass = Class.forName("android.support.customtabs.CustomTabsClient");
            CustomTabsCallbackClass = Class.forName("android.support.customtabs.CustomTabsCallback");
            CustomTabsSessionClass = Class.forName("android.support.customtabs.CustomTabsSession");
            ICustomTabsServiceClass = Class.forName("android.support.customtabs.ICustomTabsService");
        } catch (Exception t) {
            isCustomTabsAvailable_ = false;
        }
    }

On the face of it then, I'm not sure if things will work correctly without Jetifier (as there is no androidx lookup above) - can you confirm ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants
@mattt-seek and others