Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tree Tent test improvements #701

Open
charlestian23 opened this issue Dec 13, 2023 · 0 comments
Open

Tree Tent test improvements #701

charlestian23 opened this issue Dec 13, 2023 · 0 comments

Comments

@charlestian23
Copy link
Collaborator

charlestian23 commented Dec 13, 2023

Just reposting some of the improvements we can make to Tree Tent:

TooFewTents: Using a 1x1 board might be an edge case itself ... I would add a test case with a 2x2 or 3x3 board where the contradiction occurs in only one or some of the columns or rows ... analogous to what you do with testing TooManyTents

For any of the contradiction rules: please make sure you test for incorrect or 'false' applications of those rules, i.e. that LEGUP correctly responds by saying that some contradiction rule does not check out ... because there is indeed no contradiction of the kind that the contradiction rule is supposed to point out.

Same with Direct rules: make sure to have test cases where the Direct rule application should not check out

Starting with FinishWithGrass: please comment test cases

Originally posted by @Bram28 in #683 (review)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant