Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeseries fire() redundancy. #143

Open
stuart-knock opened this issue Jan 30, 2018 · 0 comments
Open

Timeseries fire() redundancy. #143

stuart-knock opened this issue Jan 30, 2018 · 0 comments

Comments

@stuart-knock
Copy link
Member

The replication of timeseries to a vector length nodes for Q is redundant when there is no explicit space to them. A single number would be all that needs to be returned with mapping to nodes done in Timeseries::fire(). The current exception is for noise, where we want a different random sequence at each point in space and typically it is applied to all nodes anyway. To maintain a consistent interface, it is probably best to have the vector returned by the individual TIMESERIES fire() methods be of length the number of nodes that the stimulus will be applied to... This becomes more important for higher resolution surfaces, where currently applying a stimulus to a single node of a 1000x1000 surface will produce a million element vector, rather than the single number that is required...

@stuart-knock stuart-knock self-assigned this Jan 30, 2018
@stuart-knock stuart-knock added this to the TBD 1 milestone Feb 9, 2018
@stuart-knock stuart-knock removed their assignment Sep 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant