Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor timeseries to make individual functions (eg, white, sine) and their parameters consistent #138

Closed
pausz opened this issue Dec 12, 2017 · 1 comment
Closed

Refactor timeseries to make individual functions (eg, white, sine) and their parameters consistent #138

pausz opened this issue Dec 12, 2017 · 1 comment
Assignees
@stuart-knock @pausz
Labels
refactor
Milestone
Paper Publication

Comments

@pausz
Copy link
Contributor

pausz commented Dec 12, 2017 •
edited
Loading

  • Use one variable per input parameter
  • Use consistent keywords across different derived Timeseries classes
  • Use simulation length, if possible (?), otherwise use numeric limits for type double as suggested by @stuart-knock
  • Document parameters and their units
@pausz pausz added the refactor label Dec 12, 2017
stuart-knock added a commit to stuart-knock/nftsim that referenced this issue Dec 20, 2017
@stuart-knock
Uses different variables for different input parameters BrainDynamics…
915c8dd 
…USYD#138.
@pausz pausz added this to the Mark II milestone Jan 23, 2018
@stuart-knock stuart-knock mentioned this issue Jan 30, 2018
Merged
@pausz
Copy link
Contributor Author

pausz commented Feb 5, 2018

#144 fixes the issue

@pausz pausz closed this as completed Feb 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stuart-knock stuart-knock

@pausz pausz

Labels
refactor
Projects
None yet
Milestone
Paper Publication
Development

No branches or pull requests
2 participants
@stuart-knock @pausz