Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup the notebooks and make correspondence to papers figures clear #12

Open
1 of 4 tasks
JesseLivezey opened this issue Sep 26, 2019 · 3 comments
Open
1 of 4 tasks

Comments

@JesseLivezey
Copy link
Member

JesseLivezey commented Sep 26, 2019

  • Fig 1
  • Fig 2
  • Fig 3
  • Fig 4
@JunwenBai
Copy link

Hi, Jesse,
Have you cleaned up the notebooks ever? I think most of the ipython notebooks *.ipynb fail to run. Do you mind looking into them? Thx
Best

@JesseLivezey
Copy link
Member Author

Thanks for bumping this. I'll try and make progress in the next few weeks. I should be able to get at least the Fig 1 notebook cleaned up fairly quickly.

@JunwenBai
Copy link

Thank you so much! I tried to reproduce the Fig 1 results using lorenz_fig.ipynb, but DCA was giving almost the same results as PCA. T_T Many thanks for working on this!
Btw, do you mind also providing the datasets or the links to the datasets for other notebooks? e.g. sabes, neural data. Most notebooks are not working basically due to 3 reasons: 1. CCA instead of DCA. And simply replacing CCA with DCA is not solving the problem. 2. Lack of datasets. Many datasets still have special data paths. 3. Deprecated functions. For instance, function random_basis has a new argument rng, while many ipynbs still overlook this arg.
Anyway, really appreciate it if you can clean up the codes. The paper is quite intriguing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants