Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App Submission: OpenStream Music (Uses scripts to install) #2469

Closed
3 tasks done
techguy16 opened this issue Oct 18, 2023 · 33 comments
Closed
3 tasks done

App Submission: OpenStream Music (Uses scripts to install) #2469

techguy16 opened this issue Oct 18, 2023 · 33 comments

Comments

@techguy16
Copy link

techguy16 commented Oct 18, 2023

What is the name of the app?

OpenStream Music

(Optional) Where is the app hosted?

https://github.com/openstreamorg/openstreammusic/

About the app

It is a free and open source music streaming service that has no ads or accounts. It uses its own database or YouTube Music's if it doesn't have the song.

Upload file or Add PR Link

OpenStream Music.zip

Confirmations

@github-actions
Copy link
Contributor

A zipfile was found in the body of your issue.
The sha1sum of the zip was: a0af1bba48175d0b6f11b1ca1bcc4cfd377e9f00

Click to show contents preview

OpenStream Music/uninstall

#!/bin/bash

#Allow packages required by this app to be uninstalled
purge_packages || exit 1

OpenStream Music/install-32

#!/bin/bash

version=1.2.0

install_packages https://github.com/openstreamorg/openstreammusic/releases/download/v${version}/openstreammusic_${version}_armv7l.deb || error 'Failed to install OpenStream Music'

OpenStream Music/install-64

#!/bin/bash

version=1.2.0

install_packages https://github.com/openstreamorg/openstreammusic/releases/download/v${version}/openstreammusic_${version}_arm64.deb || error 'Failed to install OpenStream Music'

OpenStream Music/description

Freeing the world of 'freemium' streaming services.
OpenStream Music is the only free, open source, accounts free and even ad free streaming service in the whole world! Doesn't that feel good?
To open OpenStream Music on your Pi, open the menu and go to the 'Sound & Video' section, where you will spot 'OpenStream Music'

OpenStream Music/website

https://openstreamorg.github.io

@github-actions
Copy link
Contributor

Hello there 👋
Thanks for submitting your first issue to the Pi-Apps project! We'll try to get back to you as soon as possible.
In the meantime, we encourage you join our Discord server, where you can ask any questions you might have.

Please respond as soon as possible if a Pi-Apps maintainer requests more information from you. Stale issues will be closed after a lengthy period of time with no response.

@Botspot
Copy link
Owner

Botspot commented Oct 18, 2023

Are there openstream servers providing cached music, or does this use something like youtube-dl or yt-dlp as the backend?
The reason I ask is because I once wrote a program like this called PiTunes - it was never finished it but it was a very similar idea.

@techguy16
Copy link
Author

techguy16 commented Oct 18, 2023

It uses ytdl (a node frontend for YouTube-DL)

EDIT: We don't have servers so it's easier to do it on the client side.

@techguy16
Copy link
Author

You could contribute some features from PiTunes if you wanted?

@Botspot
Copy link
Owner

Botspot commented Oct 18, 2023

You could contribute some features from PiTunes if you wanted?

PiTunes is all a bash script. Most of the code was to handle a playlist behavior with random ordering, editing, automatically splitting songs based on timestamps found in the description, and allowing manual trimming of each audio segment. It also had a simple scripting language for importing other people's playlists. I doubt any of that could transfer over to a project written in node.

@techguy16
Copy link
Author

I was only meaning suggestions. Are you merging or closing?

@theofficialgman
Copy link
Collaborator

It is a free and open source music streaming service that has no ads or accounts. It uses its own database or YouTube Music's if it doesn't have the song.

To me this sounds like a GUI frontend for piracy. You need to explain what is included in your database, where you steam those files from, and what license you have for that media where applicable.

@techguy16
Copy link
Author

techguy16 commented Oct 19, 2023

You cannot download anything.
They come directly from Google's servers.

What's your opinion on Youtubuddy then? It's the same concept.

@theofficialgman
Copy link
Collaborator

You cannot download anything. They come directly from Google's servers.

What's your opinion on Youtubuddy then? It's the same concept.

You did not define what the "own database" is. That is what I was asking about.

Streaming from YouTube using their API is already proven legal (in the US at least) and there isn't any debate about that. I was not asking about that part though.

@techguy16
Copy link
Author

techguy16 commented Oct 19, 2023

It's a json file with links to some mp3s.
It's currently in progress to remove as we now use YT Music.

@Botspot
Copy link
Owner

Botspot commented Oct 21, 2023

It seems that user techguy16 is giving us minimal information. (spoonfeeding)
It's okay. You're welcome to go in depth. We can handle it. @techguy16, please explain the full flow of information - like how the user picks songs, how they are served up, how the audio is downloaded, and from where, and how it is stored, and if you have thought through legal implications like the situation youtube-dl had to undergo.

@techguy16
Copy link
Author

techguy16 commented Oct 21, 2023

The user can choose from the "database" JSON that we have (set to be removed soon) on the homepage or search YouTube Music.
It then searches YouTube Music for that song. After that YTDL-Core gets the mp3 url and streams it if the song is clicked. The audio cannot be downloaded from YT Music, so you can only play it.
As of now I'm currently working on scrubbing cache after a song is played.

@theofficialgman
Copy link
Collaborator

One thing I notice quickly is the ancient version of electron used.
This is very dangerous given that your application loads images and is vulnerable to the webp CVE (and many others)
https://github.com/openstreamorg/openstreammusic/blob/b7a8a108e1d684cb2670da4162358f062539e5a5/desktop/package-lock.json#L4164-L4174

Please use one of the actively supported stable electron releases https://releases.electronjs.org/

@techguy16
Copy link
Author

techguy16 commented Oct 22, 2023

Hey @theofficialgman, in 1.3 I'm updating it to Electron 22 so I can still support Win7 but patch many security issues. (Commit f23ea5a)

And the bit about YouTube-DL and the legal stuff, it's not my problem. If the ytdl-core project dies, the Internet Archive it is.

@theofficialgman
Copy link
Collaborator

Hey @theofficialgman, in 1.3 I'm updating it to Electron 22 so I can still support Win7 but patch many security issues. (Commit f23ea5a)

22 is also EOL as of 2+ weeks ago so that isn't enough. People have had years of extra time to move off of that platform. Sorry it's time to let that OS support die.

If you want to support windows 7, don't use a browser as your GUI toolkit.

@techguy16
Copy link
Author

Supply a separate build for Win7?

@Botspot
Copy link
Owner

Botspot commented Oct 22, 2023

Supply a separate build for Win7?

That is up to you, @techguy16.

@techguy16
Copy link
Author

What I'm now doing:

  • Windows 7&8 and 10&11 have a separate build (npm run install-app-deps-win7 for Windows 7 and npm run install-app-deps for 10&11)
  • Linux uses the latest Electron version.

Please wait until 1.3 is release before merging (only if you are).

@techguy16
Copy link
Author

Updated to Version 1.3

@github-actions
Copy link
Contributor

A zipfile was found in the body of your issue.
The sha1sum of the zip was: 4e60afebc87b1b2dc8fd0083324c9e3d1717b0fe

Click to show contents preview

OpenStream Music/description

Freeing the world of 'freemium' streaming services.
OpenStream Music is the only free, open source, accounts free and even ad free streaming service in the whole world! Doesn't that feel good?
To open OpenStream Music on your Pi, open the menu and go to the 'Sound & Video' section, where you will spot 'OpenStream Music'

OpenStream Music/website

https://openstreamorg.github.io

OpenStream Music/install-32

#!/bin/bash

version=1.3.0

install_packages https://github.com/openstreamorg/openstreammusic/releases/download/v${version}/openstreammusic_${version}_armv7l.deb || error 'Failed to install OpenStream Music'

OpenStream Music/install-64

#!/bin/bash

version=1.3.0

install_packages https://github.com/openstreamorg/openstreammusic/releases/download/v${version}/openstreammusic_${version}_arm64.deb || error 'Failed to install OpenStream Music'

OpenStream Music/uninstall

#!/bin/bash

#Allow packages required by this app to be uninstalled
purge_packages || exit 1

@theofficialgman
Copy link
Collaborator

OpenStream Music/website

https://openstreamorg.github.io

the linked website does not exist/work

@techguy16
Copy link
Author

techguy16 commented Oct 23, 2023

@theofficialgman it's the homepage for OpenStream, the organization that "owns" OpenStream Music.
It does work by the way.

@theofficialgman
Copy link
Collaborator

it is a very good and descriptive homepage if it is working as intended
image

@Botspot
Copy link
Owner

Botspot commented Oct 23, 2023

The site is working for me.

@Sussy-OS
Copy link
Contributor

Sussy-OS commented Oct 23, 2023

it is a very good and descriptive homepage if it is working as intended image

It works for me as well. It must be an issue on your end.

@theofficialgman
Copy link
Collaborator

manually changed to http
got some info

image

currently on university connection.... I doubt it was manually blocked. Something on their scraper must have found something phishy on the webpage. Was this domain owned before by something else maybe?

@Botspot
Copy link
Owner

Botspot commented Oct 23, 2023

@techguy16, I have given OpenStream a try. It looks good in some ways. As a test user, I found some issues and opened some support issues on your github. https://github.com/openstreamorg/openstreammusic/issues

After my review, I concluded that currently OpenStream seems to still be in alpha stage - with significant issues present. My recommendation is to get the app to a high level of "functional" before it is added to the largest ARM Linux app store.

@techguy16
Copy link
Author

@Botspot, 2.0 is on the cards, which is a major revamp and fixes lots.
It is designed for Pi 4's and up, even though it runs on my Pi 3B+.
Thank you for your time and trying OpenStream Music. I see some of the issues are quick fixes, so I'll get onto them pretty soon.

@Botspot
Copy link
Owner

Botspot commented Dec 1, 2023

@techguy16, have you dropped work on this?

@techguy16
Copy link
Author

techguy16 commented Dec 2, 2023

No, I've just got distracted with other random things 😀 (Such as LinStore, which competes with Pi-Apps, don't get angry)

@Botspot
Copy link
Owner

Botspot commented Feb 10, 2024

Should I just go ahead and close this issue then?

@techguy16
Copy link
Author

For now, I'll get back eventually (hopefully...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants