-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
App Submission: OpenStream Music (Uses scripts to install) #2469
Comments
A zipfile was found in the body of your issue. Click to show contents preview
#!/bin/bash
#Allow packages required by this app to be uninstalled
purge_packages || exit 1
#!/bin/bash
version=1.2.0
install_packages https://github.com/openstreamorg/openstreammusic/releases/download/v${version}/openstreammusic_${version}_armv7l.deb || error 'Failed to install OpenStream Music'
#!/bin/bash
version=1.2.0
install_packages https://github.com/openstreamorg/openstreammusic/releases/download/v${version}/openstreammusic_${version}_arm64.deb || error 'Failed to install OpenStream Music'
|
Hello there 👋 Please respond as soon as possible if a Pi-Apps maintainer requests more information from you. Stale issues will be closed after a lengthy period of time with no response. |
Are there openstream servers providing cached music, or does this use something like youtube-dl or yt-dlp as the backend? |
It uses ytdl (a node frontend for YouTube-DL) EDIT: We don't have servers so it's easier to do it on the client side. |
You could contribute some features from PiTunes if you wanted? |
PiTunes is all a bash script. Most of the code was to handle a playlist behavior with random ordering, editing, automatically splitting songs based on timestamps found in the description, and allowing manual trimming of each audio segment. It also had a simple scripting language for importing other people's playlists. I doubt any of that could transfer over to a project written in node. |
I was only meaning suggestions. Are you merging or closing? |
To me this sounds like a GUI frontend for piracy. You need to explain what is included in your database, where you steam those files from, and what license you have for that media where applicable. |
You cannot download anything. What's your opinion on Youtubuddy then? It's the same concept. |
You did not define what the "own database" is. That is what I was asking about. Streaming from YouTube using their API is already proven legal (in the US at least) and there isn't any debate about that. I was not asking about that part though. |
It's a json file with links to some mp3s. |
It seems that user techguy16 is giving us minimal information. (spoonfeeding) |
The user can choose from the "database" JSON that we have (set to be removed soon) on the homepage or search YouTube Music. |
One thing I notice quickly is the ancient version of electron used. Please use one of the actively supported stable electron releases https://releases.electronjs.org/ |
Hey @theofficialgman, in 1.3 I'm updating it to Electron 22 so I can still support Win7 but patch many security issues. (Commit f23ea5a) And the bit about YouTube-DL and the legal stuff, it's not my problem. If the ytdl-core project dies, the Internet Archive it is. |
22 is also EOL as of 2+ weeks ago so that isn't enough. People have had years of extra time to move off of that platform. Sorry it's time to let that OS support die. If you want to support windows 7, don't use a browser as your GUI toolkit. |
Supply a separate build for Win7? |
That is up to you, @techguy16. |
What I'm now doing:
Please wait until 1.3 is release before merging (only if you are). |
Updated to Version 1.3 |
A zipfile was found in the body of your issue. Click to show contents preview
#!/bin/bash
version=1.3.0
install_packages https://github.com/openstreamorg/openstreammusic/releases/download/v${version}/openstreammusic_${version}_armv7l.deb || error 'Failed to install OpenStream Music'
#!/bin/bash
version=1.3.0
install_packages https://github.com/openstreamorg/openstreammusic/releases/download/v${version}/openstreammusic_${version}_arm64.deb || error 'Failed to install OpenStream Music'
#!/bin/bash
#Allow packages required by this app to be uninstalled
purge_packages || exit 1
|
the linked website does not exist/work |
@theofficialgman it's the homepage for OpenStream, the organization that "owns" OpenStream Music. |
The site is working for me. |
@techguy16, I have given OpenStream a try. It looks good in some ways. As a test user, I found some issues and opened some support issues on your github. https://github.com/openstreamorg/openstreammusic/issues After my review, I concluded that currently OpenStream seems to still be in alpha stage - with significant issues present. My recommendation is to get the app to a high level of "functional" before it is added to the largest ARM Linux app store. |
@Botspot, 2.0 is on the cards, which is a major revamp and fixes lots. |
@techguy16, have you dropped work on this? |
No, I've just got distracted with other random things 😀 (Such as LinStore, which competes with Pi-Apps, don't get angry) |
Should I just go ahead and close this issue then? |
For now, I'll get back eventually (hopefully...) |
What is the name of the app?
OpenStream Music
(Optional) Where is the app hosted?
https://github.com/openstreamorg/openstreammusic/
About the app
It is a free and open source music streaming service that has no ads or accounts. It uses its own database or YouTube Music's if it doesn't have the song.
Upload file or Add PR Link
OpenStream Music.zip
Confirmations
The text was updated successfully, but these errors were encountered: