PR for Open-Typer app request #2421

Sussy-OS · 2023-08-05T18:24:11Z

This PR is for adding Open-Typer to pi-apps.

Botspot · 2023-08-05T18:32:36Z

apps/Open-Typer/install-32

+echo "[Desktop Entry]
+Name=Open-Typer
+Comment=An Open Source spiritual successor to the flash game Line Rider
+Icon=$(dirname "$0")/icon-64.png
+Exec=/opt/Open-Typer.AppImage %f
+Type=Application
+Terminal=false
+Categories=Utility;" | sudo tee /usr/local/share/applications/Open-Typer.desktop >/dev/null || error "Failed to create menu button!"


Are you sure Utility is the best category for this? I was thinking Education would be the best fit.

Please update the comment.

The %f argument in the Exec line denotes the ability to open files. Does Open-Typer actually have the ability to open any kind of files?

Meant to change from Utility to Education, sorry. Did not know how to execute an appimage from a menu entry, and saw both Cura and OpenSCAD use it, so I put it in. adazem009 says that there might be opening files in the future.

Any idea what %U does? adazem009 thought it was also files.

A quick search told me it was for accessing urls.

Botspot · 2023-08-05T18:33:01Z

Any suggestions for which category this would fit best in?

adazem009 · 2023-08-05T18:35:41Z

Any suggestions for which category this would fit best in?

I'm the developer of Open-Typer and I use the Education category in all .desktop files. For example: https://github.com/Open-Typer/Open-Typer/blob/master/res/linux-release/usr/share/applications/open-typer-appimage.desktop

Sussy-OS · 2023-08-05T19:27:41Z

Accidentally kept the wrong comment in the menu entry, so just fixed that. All seems well and mergeable now.

Botspot · 2023-08-05T19:39:46Z

Any suggestions for which category this would fit best in?

I'm the developer of Open-Typer and I use the Education category in all .desktop files. For example: https://github.com/Open-Typer/Open-Typer/blob/master/res/linux-release/usr/share/applications/open-typer-appimage.desktop

Sorry, I meant pi-apps category. We don't have an education category, because until now everything educational has been about coding, so we've put them all in the Programming category.

I will give this a quick test soon and afterwards will probably have a better idea where it best fits.

Sussy-OS · 2023-08-05T19:46:14Z

Any suggestions for which category this would fit best in?

I'm the developer of Open-Typer and I use the Education category in all .desktop files. For example: https://github.com/Open-Typer/Open-Typer/blob/master/res/linux-release/usr/share/applications/open-typer-appimage.desktop

Sorry, I meant pi-apps category. We don't have an education category, because until now everything educational has been about coding, so we've put them all in the Programming category.

I will give this a quick test soon and afterwards will probably have a better idea where it best fits.

Tools possibly? I would still try it though, so you can get a better opinion.

theofficialgman · 2023-08-05T22:51:51Z

please stop doing this f65b36d (merge commit). You should use the rebase tool (via git or your favorite git GUI client such as Github Desktop)

it dirtys the git history and makes it impossible for our CI to run.
you have multiple files that have incorrect permissions btw (need executable bit set)

apps/Open-Typer/install-32

Sussy-OS · 2023-08-06T03:13:00Z

please stop doing this f65b36d (merge commit). You should use the rebase tool (via git or your favorite git GUI client such as Github Desktop)

it dirtys the git history and makes it impossible for our CI to run. you have multiple files that have incorrect permissions btw (need executable bit set)

Will remember.

Sussy-OS · 2023-08-06T20:25:59Z

Are there any other issues? I have tested it, and it runs perfectly.

theofficialgman · 2023-08-06T22:59:27Z

sorry going to have to close this. it can't be included with such high GLIBC requirements. that means it can't run on buster and bionic.

/tmp/.mount_Open-T8ijOB6/AppRun.wrapped: /lib/aarch64-linux-gnu/libm.so.6: version `GLIBC_2.29' not found (required by /tmp/.mount_Open-T8ijOB6/usr/bin/../lib/libQt6Widgets.so.6)
/tmp/.mount_Open-T8ijOB6/AppRun.wrapped: /lib/aarch64-linux-gnu/libm.so.6: version `GLIBC_2.29' not found (required by /tmp/.mount_Open-T8ijOB6/usr/bin/../lib/libQt6Quick.so.6)
/tmp/.mount_Open-T8ijOB6/AppRun.wrapped: /lib/aarch64-linux-gnu/libm.so.6: version `GLIBC_2.29' not found (required by /tmp/.mount_Open-T8ijOB6/usr/bin/../lib/libQt6Gui.so.6)
/tmp/.mount_Open-T8ijOB6/AppRun.wrapped: /lib/aarch64-linux-gnu/libm.so.6: version `GLIBC_2.29' not found (required by /tmp/.mount_Open-T8ijOB6/usr/bin/../lib/libQt6Qml.so.6)
/tmp/.mount_Open-T8ijOB6/AppRun.wrapped: /lib/aarch64-linux-gnu/libm.so.6: version `GLIBC_2.29' not found (required by /tmp/.mount_Open-T8ijOB6/usr/bin/../lib/libQt6Core.so.6)
/tmp/.mount_Open-T8ijOB6/AppRun.wrapped: /lib/aarch64-linux-gnu/libc.so.6: version `GLIBC_2.28' not found (required by /tmp/.mount_Open-T8ijOB6/usr/bin/../lib/libQt6Core.so.6)
/tmp/.mount_Open-T8ijOB6/AppRun.wrapped: /lib/aarch64-linux-gnu/libm.so.6: version `GLIBC_2.29' not found (required by /tmp/.mount_Open-T8ijOB6/usr/bin/../lib/libQt6OpenGL.so.6)
/tmp/.mount_Open-T8ijOB6/AppRun.wrapped: /lib/aarch64-linux-gnu/libc.so.6: version `GLIBC_2.28' not found (required by /tmp/.mount_Open-T8ijOB6/usr/bin/../lib/libglib-2.0.so.0)
/tmp/.mount_Open-T8ijOB6/AppRun.wrapped: /lib/aarch64-linux-gnu/libm.so.6: version `GLIBC_2.29' not found (required by /tmp/.mount_Open-T8ijOB6/usr/bin/../lib/libpng16.so.16)
/tmp/.mount_Open-T8ijOB6/AppRun.wrapped: /lib/aarch64-linux-gnu/libm.so.6: version `GLIBC_2.29' not found (required by /tmp/.mount_Open-T8ijOB6/usr/bin/../lib/libicui18n.so.66)
/tmp/.mount_Open-T8ijOB6/AppRun.wrapped: /lib/aarch64-linux-gnu/libm.so.6: version `GLIBC_2.29' not found (required by /tmp/.mount_Open-T8ijOB6/usr/bin/../lib/libicuuc.so.66)
/tmp/.mount_Open-T8ijOB6/AppRun.wrapped: /lib/aarch64-linux-gnu/libc.so.6: version `GLIBC_2.28' not found (required by /tmp/.mount_Open-T8ijOB6/usr/bin/../lib/libsystemd.so.0)
/tmp/.mount_Open-T8ijOB6/AppRun.wrapped: /lib/aarch64-linux-gnu/libc.so.6: version `GLIBC_2.30' not found (required by /tmp/.mount_Open-T8ijOB6/usr/bin/../lib/libsystemd.so.0)

@adazem009 we can re-open if you build your appimages on an older distro for compatabiilty. I suggest setting up build chroots or docker containers on ubuntu bionic. keep in mind that github actions (since I see you use it at least partially for CI purposes) can build in a docker container easily with container: nameofcontainer at the same level as the runs-on: version. eg: container: ubuntu:18.04

edit: also, I suggest simply using the following QT6 ppa rather than bulding it from source unless you need something newer than 6.2 or have custom patches https://launchpad.net/~okirby/+archive/ubuntu/qt6-backports

edit2: I'm also not opposed to a flatpak but we can't/won't do snaps

adazem009 · 2023-08-07T06:26:50Z

@theofficialgman I checked that PPA before, but I need at least Qt 6.4, so it's better to cross-compile it on x86 (building it in inside an emulator is definitely not a choice because of GitHub Actions limit).

I'll try to build Open-Typer 5.3 on an older distro (I'll release it in October).

adazem009 · 2023-10-01T10:09:19Z

@theofficialgman I think I'll keep the builds on Ubuntu 20.04. Bionic has a too old toolchain and I need at least C++17 for Qt 6. I've been trying to build a gcc cross compiler myself for a few weeks, but even after I'd managed to do it, it didn't pass the "compiler tests" Qt runs before building.

I'll move this to the next minor version and try to build Qt 6 in a PPA instead. It should be easier to build it directly on the target architecture.

Botspot · 2023-10-14T06:17:15Z

Reopening now that we have dropped Buster and Bionic support.

at some point I will stop caring

theofficialgman · 2023-10-22T00:52:01Z

@Sussy-OS thanks for the PR, it has been merged
@adazem009 thanks for the development of this application. One thing I will note about it is the displayed keyboard seems useless to me since it can't be interacted with (ubuntu gnome 22.04 x11 session with a device with a builtin touchscreen). I am sure that is intentional, it just looks like on on-screen intractable keyboard to me

adazem009 · 2023-10-22T08:47:59Z

@Sussy-OS thanks for the PR, it has been merged
@adazem009 thanks for the development of this application. One thing I will note about it is the displayed keyboard seems useless to me since it can't be interacted with (ubuntu gnome 22.04 x11 session with a device with a builtin touchscreen). I am sure that is intentional, it just looks like on on-screen intractable keyboard to me

The application is designed specifically for the desktop to help people learn to type on a physical keyboard.
I don't think it would make sense to make it interactable because there are many different on-screen keyboards people use.

However, I could show the native keyboard on touch screen devices instead.

Sussy-OS mentioned this pull request Aug 5, 2023

[Install based app request] Open-Typer App request #2422

Closed

3 tasks

Botspot reviewed Aug 5, 2023

View reviewed changes

Sussy-OS added 7 commits August 5, 2023 18:58

Add Open-Typer to apps directory

134b12b

Update install-32

5bcb666

Update install-64

d4bf0a4

Update install-32

c7515bd

Create Open-Typer.sh

d78c04e

Change category to education

4ce55af

copy paste mess up

fc5a351

theofficialgman force-pushed the master branch from 9b3772b to fc5a351 Compare August 5, 2023 22:58

Correct file permissions for install and uninstall files

3aedb97

theofficialgman reviewed Aug 5, 2023

View reviewed changes

apps/Open-Typer/install-32 Outdated Show resolved Hide resolved

Sussy-OS added 2 commits August 6, 2023 15:11

Combine install-32 and install-64 as well as fix fuse implementation

1800574

Change accessories to education in description

01609ed

theofficialgman closed this Aug 6, 2023

adazem009 mentioned this pull request Aug 7, 2023

[TASK] Build arm AppImages on Ubuntu 18.04 Open-Typer/Open-Typer#76

Open

Botspot reopened this Oct 14, 2023

add category and minor updates

d0f5d51

theofficialgman added 2 commits October 21, 2023 20:35

Update category-overrides-jetson-18.04

37bcc99

at some point I will stop caring

two spaces not tabs

5628d3d

theofficialgman merged commit f24028d into Botspot:master Oct 22, 2023
2 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PR for Open-Typer app request #2421

PR for Open-Typer app request #2421

Sussy-OS commented Aug 5, 2023

Botspot Aug 5, 2023

Sussy-OS Aug 5, 2023 •

edited

Loading

Sussy-OS Aug 5, 2023 •

edited

Loading

Sussy-OS Aug 5, 2023

Botspot commented Aug 5, 2023

adazem009 commented Aug 5, 2023

Sussy-OS commented Aug 5, 2023

Botspot commented Aug 5, 2023

Sussy-OS commented Aug 5, 2023

theofficialgman commented Aug 5, 2023 •

edited

Loading

Sussy-OS commented Aug 6, 2023

Sussy-OS commented Aug 6, 2023

theofficialgman commented Aug 6, 2023 •

edited

Loading

adazem009 commented Aug 7, 2023

adazem009 commented Oct 1, 2023

Botspot commented Oct 14, 2023

theofficialgman commented Oct 22, 2023 •

edited

Loading

adazem009 commented Oct 22, 2023

PR for Open-Typer app request #2421

PR for Open-Typer app request #2421

Conversation

Sussy-OS commented Aug 5, 2023

Botspot Aug 5, 2023

Choose a reason for hiding this comment

Sussy-OS Aug 5, 2023 • edited Loading

Choose a reason for hiding this comment

Sussy-OS Aug 5, 2023 • edited Loading

Choose a reason for hiding this comment

Sussy-OS Aug 5, 2023

Choose a reason for hiding this comment

Botspot commented Aug 5, 2023

adazem009 commented Aug 5, 2023

Sussy-OS commented Aug 5, 2023

Botspot commented Aug 5, 2023

Sussy-OS commented Aug 5, 2023

theofficialgman commented Aug 5, 2023 • edited Loading

Sussy-OS commented Aug 6, 2023

Sussy-OS commented Aug 6, 2023

theofficialgman commented Aug 6, 2023 • edited Loading

adazem009 commented Aug 7, 2023

adazem009 commented Oct 1, 2023

Botspot commented Oct 14, 2023

theofficialgman commented Oct 22, 2023 • edited Loading

adazem009 commented Oct 22, 2023

Sussy-OS Aug 5, 2023 •

edited

Loading

Sussy-OS Aug 5, 2023 •

edited

Loading

theofficialgman commented Aug 5, 2023 •

edited

Loading

theofficialgman commented Aug 6, 2023 •

edited

Loading

theofficialgman commented Oct 22, 2023 •

edited

Loading