Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Taxonomy labels custom routing, interferes with 'Edit labels' route #44

Open
sbonardt opened this issue Mar 31, 2017 · 1 comment

Comments

@sbonardt
Copy link

sbonardt commented Mar 31, 2017

Hi,

don't know where to put this, but I figured I start out at the labels extension. I have a tags taxonomy type named: 'labels'

I want to view this in the frontend under the route: /locaties/{taxonomytype}/{slug}

Therefor I have a routing:

labels:
  path:  /locaties/{taxonomytype}/{slug}
  defaults:  { _controller: 'Bolt\Controllers\Frontend::taxonomy' }
  requirements:
    taxonomytype: 'labels'

This all works like a charm, however. I now can not access the eedit labels page for the labels extension: /bolt/extend/labels

the page loads with the following error:

NotFoundHttpException in RouterListener.php line 176:
No route found for "GET /bolt/extend/labels" 

Removing the addition in routing.yml solves it. But I want that routing! Where's the bug?

Using Bolt 3.2.9 and Labels 3.0.7

@SvanteRichter
Copy link
Contributor

Yeah, the site routing.yml takes higher precedence than the extension added routes. This is also the reason for https://discuss.bolt.cm/d/6-routing-for-sitemap-while-using-pagebinding. It isn't really an issue with this extension, but it could be fixed in this particular instance by naming the route something slightly more unique in the extension like "extensionBoltLabels" or whatever.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants