Seasonal Animations mod - domain expired

[jramseygreen]

The domain required for https://github.com/BobHasNoSoul/jellyfin-mods/tree/main?tab=readme-ov-file#seasonal-animations No longer resolves. (http://git.bbod.tk/BobHasNoSoul/jellyfin-mods.git)

[BobHasNoSoul]

i see thats from when i was running my own git for experimental builds of things lol, okay so i cannot reccomend doing this until i get a chance to update it for 10.9.x (it is on the list but this is one of the few things that will take a few to implement because of how different the code is now to how it was) i am currently in the process of porting all of these over to the new version of jellyfin (10.9.x including all of the other mods) so far im about 40% done and it should be a solid day tomorrow of getting the rest done and if possible port those too

note the way the old seasonal animations mod worked im pretty sure will not work in 10.9.x because of how the index page gets loaded now.. but i have ideas.

thank you for showing interest and letting me know about that typo it will be fixed and updated when it is ready for the latest jellyfin.

[jramseygreen]

Not really related to this ticket, but I'd love to figure out a way of binding buttons / tabs to popping a modal which can be filled with custom content.

Unsure how feasible that really is however when we are just modifying the compiled frontend code

[BobHasNoSoul]

Not really related to this ticket, but I'd love to figure out a way of binding buttons / tabs to popping a modal which can be filled with custom content.

Unsure how feasible that really is however when we are just modifying the compiled frontend code

in theory you could keybind anything to do anything.. however it depends entirely what you mean can you expand on it so i get a better idea of what you actually mean.

it sounds like you mean something like

if userX logs in and presses the , key it will open playlists window inside jellyfin? or do you mean a new window of completely different content.. or to open a window inside of the current window (like an iframe)

[jramseygreen]

I'm talking about adding a menu item, and having it open a different page / modal which will have custom html inside. My use case specifically is for an iframe.

This is so that for example there could be an embedded requests tab with jellyseerr embedded.

I know that there is already the mod for the trailers channel and the one I added a while ago for the upcoming tab in shows libraries - but this doesn't feel like a particularly good solution.

[BobHasNoSoul]

In theory that's actually not a bad idea... It can be done however it would require making a element that is hidden inside of index.html and then having it open when a function is called via JavaScript, then a case of trying to match the style of the existing install.. that last part for me would be the hardest trying to make something that works not too hard, but trying to make something that works that I can stand to look at.. that's the hard part

…

On Sun, 19 May 2024, 00:38 jramseygreen, ***@***.***> wrote: I'm talking about adding a menu item, and having it open a different page / modal which will have custom html inside. My use case specifically is for an iframe. This is so that for example there could be an embedded requests tab with jellyseerr embedded. I know that there is already the mod for the trailers channel and the one I added a while ago for the upcoming tab in shows libraries - but this doesn't feel like a particularly good solution. — Reply to this email directly, view it on GitHub <#19 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFPTXLH45JTRZATD3C34UE3ZC7Q7DAVCNFSM6AAAAABH4JBLE6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJZGAZTANRXGU> . You are receiving this because you commented.Message ID: ***@***.***>

[BobHasNoSoul]

in response to the original ticket please see

https://github.com/BobHasNoSoul/jellyfin-mods/blob/main/10.9.x.md#omg-seasonal-themes-are-back-109x

unfortunately i didnt have time to port them all, however over the next weekend.. or weekend after they should all be back to working on 10.9.x hopefully with some crontab automation also.

as for the other idea, i will think about how best to aproach this.. because it sounds useful but it would be a little hard to configure (the csp for 10.9.x is same origin by default so lets say your jellyfin install was on example.com but your jellyseer was on requests.example.com that would not work and would give an error however if the jellyseer was on a baseurl of example.com/requests that would work) this makes modificatiosn like this very very use case specific so may take a while longer than expected. (because the limiting nature of the csp.. however the csp is good becasue it does stop people from trying to inject their own scripts to your install.

[jramseygreen]

with regards to the cross site protection, I do indeed have jellyseerr hosted on a subdomain. However I don't anticipate it to be a problem, since one could simply make an extra location entry into the jellyfin nginx config for /requests pointing to jellyseerr and use that instead of the subdomain

[BobHasNoSoul]

with regards to the cross site protection, I do indeed have jellyseerr hosted on a subdomain. However I don't anticipate it to be a problem, since one could simply make an extra location entry into the jellyfin nginx config for /requests pointing to jellyseerr and use that instead of the subdomain

that would be the case if jellyseer supported returning a baseurl and also not returning a baseurl on the same instance.. to my knowlege it doesnt do this

unless you mean like some sort of nginx rewrite rule where... im not sure if that would be possible but... im now intrigued