Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

old version of pandas requirement #11

Open
Daniel-Foyt-UCSF-Berkeley opened this issue May 18, 2020 · 1 comment
Open

old version of pandas requirement #11

Daniel-Foyt-UCSF-Berkeley opened this issue May 18, 2020 · 1 comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@Daniel-Foyt-UCSF-Berkeley
Copy link

Daniel-Foyt-UCSF-Berkeley commented May 18, 2020

There is a requirement for an old version of the Pandas module in requirements.txt. Might be easier to use if you use minimum versions instead i.e pandas >= 0.25.3 unless the new version is not compatible. They only updated it a couple months ago.

@davidbrown2324 davidbrown2324 added good first issue Good for newcomers help wanted Extra attention is needed labels May 19, 2020
@davidbrown2324
Copy link
Collaborator

I agree. I won't change this yet because I want to finish the test suite before I make any changes. For users installing now, I would recommend using a virtual environment, so it shouldn't matter. But I agree these should be converted to a minimum once the tests can confirm it works with the latest versions (which I am sure they will).

@Huanglab-ucsf if anyone wants to submit the change as a pull request that would be totally welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants