feat(introspect): implement annotations #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #359 will not alter performanceComparing Summary
|
black-desk
force-pushed
the
implement-annotations
branch
from
81d25c8 to
c946b0c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #359 +/- ##
==========================================
+ Coverage 83.56% 83.70% +0.13%
==========================================
Files 28 28
Lines 3353 3381 +28
Branches 604 607 +3
==========================================
+ Hits 2802 2830 +28
Misses 344 344
Partials 207 207 ☔ View full report in Codecov by Sentry. |
|
Would you please add a description on what this PR implements to the opening text? |
black-desk
force-pushed
the
implement-annotations
branch
from
c946b0c to
c49eac6
Compare
commit message has been updated |
bdraco
approved these changes
Jan 13, 2025
|
Thanks @black-desk |
bdraco
reviewed
Jan 13, 2025
D-Bus allow annotations in introspection data: > ... > > Method, interface, property, signal, and argument elements may have > "annotations", which are generic key/value pairs of metadata. They > are similar conceptually to Java's annotations and C# attributes. > > ... https://dbus.freedesktop.org/doc/dbus-specification.html#introspection-format This commit add new attribute "annotations" to: - dbus_fast.introspection.Arg - dbus_fast.introspection.Signal - dbus_fast.introspection.Method - dbus_fast.introspection.Property - dbus_fast.introspection.Interface
black-desk
force-pushed
the
implement-annotations
branch
from
b53b99e to
fabdbdf
Compare
bdraco
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
D-Bus allow annotations in introspection data:
https://dbus.freedesktop.org/doc/dbus-specification.html#introspection-format
This commit add new attribute "annotations" to: