-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test_bthome_mass_kilograms fails on s390x because of endianness #143
Comments
I think the first byte is wrong. Anyway if you change the first byte to
If I look at the original test set, there is a different byte string and value in the test set |
Just to be clear, the test passes on little-endian architectures. |
I'm a bit surprised that the test passes. But if you change the |
I tried changing
|
And this is the unmodified test passing on amd64.
|
I see that it fails on the V1 format, not on the V2 format. The V1 format is deprecated but is explained here. https://bthome.io/v1/ The first byte is defining the length and data format, I think it goes wrong in that part. |
When I run the test suite on the s390x architecture one of the tests fails.
I'm guessing this bug is caused by s390x being big-endian.
I'm testing version 3.10.0 of bthome-ble.
Here's the test failure:
The text was updated successfully, but these errors were encountered: