Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IIRC, this 118 is the char limit being passed to decode? Since new versions of sp address can (and likely will) have more data added to the data part, might be better to use 1024 here? This is the recommended number from the BIP #15

Open
Overtorment opened this issue Jun 9, 2024 · 1 comment

Comments

@Overtorment
Copy link
Member

          IIRC, this 118 is the char limit being passed to decode? Since new versions of sp address can (and likely will) have more data added to the data part, might be better to use 1024 here? This is the recommended number from the BIP

Originally posted by @josibake in #10 (comment)

@josibake
Copy link
Contributor

Per the BIP:

  • If sender is v0 sending to spv0 (sp1q) address, check that the data part is exactly 66 bytes (two compressed public keys)
  • If sender is v0 sending to spv1 - spv30 address, check that the data part is at least 66 bytes, ignore the extra bytes
  • If sender is v0 sending to spv31 address, fail (v31 is reserved for backwards incompatible changes)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants