You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
BLOSC_ERROR calls BLOSC_TRACE_ERROR, which prints only if environment variable BLOSC_TRACE is defined
BLOSC_INFO prints directly if environment variable BLOSC_INFO is defined. Instead, I think it should call BLOSC_TRACE_INFO, which prints only if environment variable BLOSC_TRACE is defined.
I realise that it's probably unfeasible to modify things without slightly breaking backwards compatibility, but the current macros don't make sense to me: if environment only variable BLOSC_INFO is defined, BLOSC_INFO will print but BLOSC_ERROR will not print!
The text was updated successfully, but these errors were encountered:
I like your proposal of making interfaces more uniform. Right now BLOSC_INFO should not be used beyond developers, so I don't think we will break anything serious if we implement what you are proposing. Would you mind sending a PR?
Describe the bug
I am not sure I understand the tracing macros:
c-blosc2/include/blosc2.h
Lines 114 to 129 in 3ae32b6
BLOSC_ERROR
callsBLOSC_TRACE_ERROR
, which prints only if environment variableBLOSC_TRACE
is definedBLOSC_INFO
prints directly if environment variableBLOSC_INFO
is defined. Instead, I think it should callBLOSC_TRACE_INFO
, which prints only if environment variableBLOSC_TRACE
is defined.I realise that it's probably unfeasible to modify things without slightly breaking backwards compatibility, but the current macros don't make sense to me: if environment only variable
BLOSC_INFO
is defined,BLOSC_INFO
will print butBLOSC_ERROR
will not print!The text was updated successfully, but these errors were encountered: