Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notes, the multiple queries that are nested: For Labs 23 #283

Open
newbi462 opened this issue Mar 27, 2020 · 0 comments
Open

Notes, the multiple queries that are nested: For Labs 23 #283

newbi462 opened this issue Mar 27, 2020 · 0 comments

Comments

@newbi462
Copy link
Collaborator

newbi462 commented Mar 27, 2020

See note to labs 21 as a related issue.

There are multiple queries being ran in the Note and Note Editing components. For each note that exists, it will run a query which will then run another query because of the code in the Note Editor will loop back to the Note component, indefinitely. The following files, listed below, are those which are affected.

src/components/Project/index.jsx
src/components/Project/NoteEditor/index.jsx
src/components/Project/NoteFeed/index.jsx
src/components/Project/NoteFeed/Note/index.jsx

Loop Description

* Note which loops to 
* Note editor which loops to Note
* Note then loops to editor
* Forever…

FIX: Use state management and where needed use props. Remove multiple queries.
A related issue can be found here which also recommends refactoring to use Context API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant